-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Migrate NREL references to NLR (National Laboratory of the Rockies) #2705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jason-curtis
wants to merge
10
commits into
pvlib:main
Choose a base branch
from
jason-curtis:nlr-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+231
−198
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4902b20
Migrate NREL references to NLR (National Laboratory of the Rockies)
jason-curtis 08f2c27
Apply suggestions from code review
jason-curtis 1ebb8d6
Fix broken links in tmy_to_power tutorial
jason-curtis 0ae3558
Fix reference formatting in irradiance.py and pvsystem.py
jason-curtis aec4682
Migrate github.com/NREL URLs to github.com/NatLabRockies
jason-curtis 6563103
Add docs page explaining NREL to NLR rename
jason-curtis fd771e6
Fix line too long in conftest.py docstring
jason-curtis 1820fdd
Apply suggestions from @AdamRJensen CR
jason-curtis c3df9a8
Address wholmgren's review on PR #2705
jason-curtis 01ad3d8
chore: add runtime dirs to .gitignore
jason-curtis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,3 +99,8 @@ coverage.xml | |
| env | ||
| results | ||
|
|
||
|
|
||
| # Gas Town runtime | ||
| .beads/ | ||
| .claude/ | ||
| .runtime/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| .. _nrel_nlr: | ||
|
|
||
| ============================== | ||
| NREL to NLR Rename (Dec 2025) | ||
| ============================== | ||
|
|
||
| In December 2025, the U.S. Department of Energy renamed the | ||
| **National Renewable Energy Laboratory (NREL)** to the | ||
| **National Laboratory of the Rockies (NLR)**. | ||
|
|
||
|
|
||
| Domain migration | ||
| **************** | ||
|
|
||
| The lab's website moved from ``nrel.gov`` to ``nlr.gov``. The ``nrel.gov`` | ||
| domain is expected to stop resolving on **May 29, 2026**. The GitHub | ||
| organization moved from ``github.com/NREL`` to ``github.com/NatLabRockies``. | ||
| pvlib will update API and repository URLs as the migration progresses. | ||
|
|
||
|
|
||
| When we use NREL vs NLR | ||
| *********************** | ||
|
|
||
| - **NREL**: historical publications, citations, and algorithm references | ||
| (e.g. the NREL SPA) published under the original name. | ||
| - **NLR**: the current organization, its software and data products, | ||
| and new ``nlr.gov`` URLs. | ||
|
|
||
| Most existing pvlib code and docs say "NREL" because it appears in | ||
| bibliographic citations. These do not need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're adding a whole new doc page to explain our stance then we should probably link to it in the whats new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason for adding a page on this. That just seems like it'll be outdated soon and is a maintainance burden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As evidenced by the 4 rounds of feedback on this PR, I think it's worth having something that explains why we're using NREL in some places and NLR in others but happy to defer to y'all.