Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc()#2704
Open
RDaxini wants to merge 3 commits intopvlib:mainfrom
Open
Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc()#2704RDaxini wants to merge 3 commits intopvlib:mainfrom
g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc()#2704RDaxini wants to merge 3 commits intopvlib:mainfrom
Conversation
Member
Author
|
Tagged as 0.15.1 but the wrapper did allow users to use the old arg name, as well as emit a warning, so do we class it as a breaking change for 0.16.0...? |
Member
I would say yes, this should go in 0.16. |
cwhanse
approved these changes
Mar 3, 2026
Member
|
@RDaxini Could you also remove the term from the nomenclature? It's a bit of a scope creep, but I think it fits nicely here 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g_poa_effectiverenamed kwarg warning inpvsystem.pvwatts_dc()#2703docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Also removes variable from the nomenclature page