Skip to content

Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc()#2704

Open
RDaxini wants to merge 3 commits intopvlib:mainfrom
RDaxini:renamekwargwarning
Open

Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc()#2704
RDaxini wants to merge 3 commits intopvlib:mainfrom
RDaxini:renamekwargwarning

Conversation

@RDaxini
Copy link
Member

@RDaxini RDaxini commented Mar 2, 2026

  • Closes Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc() #2703
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Also removes variable from the nomenclature page

@RDaxini RDaxini added api deprecation Use for issues and PRs which involve deprecations labels Mar 2, 2026
@RDaxini RDaxini added this to the v0.15.1 milestone Mar 2, 2026
@RDaxini
Copy link
Member Author

RDaxini commented Mar 2, 2026

Tagged as 0.15.1 but the wrapper did allow users to use the old arg name, as well as emit a warning, so do we class it as a breaking change for 0.16.0...?

@AdamRJensen
Copy link
Member

Tagged as 0.15.1 but the wrapper did allow users to use the old arg name, as well as emit a warning, so do we class it as a breaking change for 0.16.0...?

I would say yes, this should go in 0.16.

@RDaxini RDaxini modified the milestones: v0.15.1, v0.16.0 Mar 2, 2026
@AdamRJensen
Copy link
Member

@RDaxini Could you also remove the term from the nomenclature? It's a bit of a scope creep, but I think it fits nicely here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api deprecation Use for issues and PRs which involve deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc()

3 participants