Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documentation ReviewThis PR modifies a GitHub Actions workflow file rather than documentation content, so standard style/content checks don't apply. I've reviewed the workflow logic instead. SummaryThe fix correctly addresses a no-op build failure. Here's a breakdown: Logic check for
Output propagation:
Job condition: if: needs.build-customer-managed-workflow-agent-cli-docs.outputs.has_changes == 'true'This correctly skips (not fails) the ResultNo issues found. The fix is minimal, correct, and well-scoped to the reported problem. If you'd like additional review or have questions, mention @claude in a comment. |
|
Your site preview for commit 7372eaa is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17663-7372eaa9.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a workflow failure that occurred when documentation for a given version was already up to date. The git commit command exits with code 1 when there's nothing to commit, causing the workflow to fail. The fix adds conditional logic to detect when there are no changes and gracefully skip the commit, push, and pull request creation steps.
Changes:
- Added conditional check using
git diff --cached --quietto detect when no changes are staged - Added
has_changesoutput variable to communicate change status between jobs - Made the
pull-requestjob conditional on thehas_changesoutput to skip PR creation when no changes exist
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
The workflow failed when the docs for a given version were already up to date, because
git commitexits 1 when there's nothing to commit. This was surfaced by a failure notification in #docs-ops.Guards the commit and push with
if git diff --cached --quiet, and gates thepull-requestjob on ahas_changesoutput so it is skipped (not failed) when no changes were made.