Skip to content

ABAC and Custom roles to users & Team Launch#17598

Merged
djgrove merged 8 commits intomasterfrom
authz-abac-launch
Mar 19, 2026
Merged

ABAC and Custom roles to users & Team Launch#17598
djgrove merged 8 commits intomasterfrom
authz-abac-launch

Conversation

@arunkumar611
Copy link
Copy Markdown
Member

@arunkumar611 arunkumar611 commented Feb 19, 2026

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 19, 2026

Documentation Review

Critical Issue

Unfished placeholder (content/blog/expanding-pulumi-iam-custom-permissions/index.md, line 77):

**<span style="color:red">Placeholder: add a video on Custom Roles</span>**

This raw HTML placeholder will render visibly in the published post with red text. It must be removed or replaced with actual content before merging.


Heading Case

Per the repository style guide, H2+ headings must use sentence case. The following headings need correction:

  • Line 31: ## What's New?## What's new?
  • Line 53: ## How to Get Started## How to get started
  • Line 79: ## Automate Governance with Pulumi Policy## Automate governance with Pulumi Policy
  • Line 148: ## Learn More## Learn more

Incomplete Code Examples

Both code blocks are missing import statements, making them incomplete as written.

TypeScript (line 89) — add at the top of the block:

import { PolicyPack } from "@pulumi/policy";

new PolicyPack("required-tags", {

Python (line 109) — add at the top of the block:

from pulumi_policy import EnforcementLevel, PolicyPack, ResourceValidationPolicy

def require_tags(args, report_violation):

Pricing Page Links to Blog Post

In content/pricing/_index.md, the two new entries link to the blog post URL:

- title: Tag-based access control
  link: /blog/expanding-pulumi-iam-custom-permissions/
- title: Assign custom roles to users and teams
  link: /blog/expanding-pulumi-iam-custom-permissions/

Blog posts are historical documents and not ideal targets for pricing table feature links. If stable documentation pages exist for these features (e.g., /docs/administration/access-identity/rbac/), those should be used instead. If docs don't exist yet, consider adding them before linking from the pricing page.


Minor

  • Line 21: "Today, we're excited to announce" is generic filler. Consider a more direct opening.
  • Line 140: "Tag-Based Access Control, Team Role Assignments, and User Role Assignments" uses title case in body text. Unless these are registered product names, prefer sentence case: "tag-based access control, team role assignments, and user role assignments."

Mention @claude if you'd like a follow-up review after changes are made.

@pulumi-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@djgrove djgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md Outdated
Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md
Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md Outdated
Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md Outdated
Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md
@pulumi-bot
Copy link
Copy Markdown
Collaborator

Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md Outdated
Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 27, 2026

@djgrove I've opened a new pull request, #17725, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Update blog post date to 2026-03-09 (one week later)

Co-authored-by: djgrove <12940616+djgrove@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: djgrove <12940616+djgrove@users.noreply.github.com>
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@djgrove djgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for now--need to adjust date since we had an incident over the weekend.

Comment thread content/blog/expanding-pulumi-iam-custom-permissions/index.md Outdated
@pulumi-bot
Copy link
Copy Markdown
Collaborator

Add generated feature and meta images, include the demo video, update the
publish date to 2026-03-18, and tighten the post to reduce repetition and
fix heading case.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pulumi-bot
Copy link
Copy Markdown
Collaborator

---
title: "Pulumi IAM Expands: Manage Access at Scale with Tags, Roles, and Teams"
allow_long_title: true
date: 2026-03-18T00:00:00-08:00
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot update this date to today at 10:30AM PDT

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 19, 2026

@djgrove I've opened a new pull request, #18063, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Update blog post date to 2026-03-19 at 10:30AM PDT

Co-authored-by: djgrove <12940616+djgrove@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: djgrove <12940616+djgrove@users.noreply.github.com>
@djgrove djgrove merged commit ed109cb into master Mar 19, 2026
8 checks passed
@djgrove djgrove deleted the authz-abac-launch branch March 19, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants