Get title of Image on URL and display on sidebar#1238
Open
Chinazaekpere-Ike wants to merge 1 commit intopubliclab:mainfrom
Open
Get title of Image on URL and display on sidebar#1238Chinazaekpere-Ike wants to merge 1 commit intopubliclab:mainfrom
Chinazaekpere-Ike wants to merge 1 commit intopubliclab:mainfrom
Conversation
|
Thanks for opening this pull request! |
Member
|
Hello, this looks good, i like it! What if we placed the title just above the "Place on map" button, though... could it be more compact that way? Thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fetched the name of the image from the inputted URL. This is the same name which the user originally saved their image on archive.org
This gotten image name s now displayed on the sidebar (beneath the gotten image) as the Image title
Fixes #1202
I @Chinazaekpere-Ike is the author of the issue
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt testIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
@jywarren Hope this looks good.