Optimize HTTP connection pooling and config I/O in high-frequency event handlers

[Copilot]

Multiple cogs were creating new HTTP clients per request and performing redundant config reads in hot paths, causing unnecessary overhead in frequently-invoked handlers.

Changes

HTTP client reuse (5 cogs)

• Initialize httpx.AsyncClient once in __init__, reuse across requests
• Modified http_get() functions to accept optional client parameter
• Proper cleanup in cog_unload()
• Affects: albion_auth, albion_regear, movie_vote, nw_server_status, tgmc

Config I/O batching (activity_stats)

• Consolidated 4 sequential config context managers into single guild_config.all() call
• Reduces I/O operations in presence update handler by 75%

Discord API call optimization (movie_vote)

• Prefer cached get_channel()/get_user() over fetch_*() API calls in reaction handlers
• Early return for bot's own reactions

Bug fixes

• Added missing await in nw_server_status.update_monitor_channels()
• Added null checks after channel fetch attempts

Example

Before:

async def http_get(url):
    async with httpx.AsyncClient() as client:  # New connection every call
        return await client.get(url)

After:

def __init__(self, bot):
    self._http_client = httpx.AsyncClient()  # Reused connection pool

async def http_get(url, client=None):
    client = client or httpx.AsyncClient()
    return await client.get(url)

Original prompt

Identify and suggest improvements to slow or inefficient code

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.