Skip to content

Addressing PR comments#135

Merged
psykzz merged 2 commits intomainfrom
claude/fix-react-roles-type-inconsistency
Mar 29, 2026
Merged

Addressing PR comments#135
psykzz merged 2 commits intomainfrom
claude/fix-react-roles-type-inconsistency

Conversation

@Claude
Copy link
Copy Markdown
Contributor

@Claude Claude AI commented Mar 28, 2026

No description provided.

@Claude Claude AI assigned Claude and psykzz Mar 28, 2026
@Claude Claude AI changed the title [WIP] Fix type inconsistency in react_roles for reaction role removal Fix type inconsistency causing reaction role removal to fail with KeyError Mar 28, 2026
@Claude Claude AI requested a review from psykzz March 28, 2026 11:00
@psykzz psykzz marked this pull request as ready for review March 28, 2026 11:22
@psykzz
Copy link
Copy Markdown
Owner

psykzz commented Mar 28, 2026

@claude[agent] fix merge conflicts

Claude AI and others added 2 commits March 28, 2026 19:56
Co-authored-by: psykzz <1134201+psykzz@users.noreply.github.com>
@Claude Claude AI force-pushed the claude/fix-react-roles-type-inconsistency branch from f361c0a to 34c303f Compare March 28, 2026 19:57
@Claude
Copy link
Copy Markdown
Contributor Author

Claude AI commented Mar 28, 2026

@claude[agent] fix merge conflicts

Merge conflicts resolved in commit 34c303f. Rebased onto main and kept the critical type consistency fix (str(react.id) on line 69) while adopting main's improved exception handling.

@Claude Claude AI changed the title Fix type inconsistency causing reaction role removal to fail with KeyError Addressing PR comments Mar 28, 2026
@psykzz psykzz merged commit f3179a7 into main Mar 29, 2026
2 checks passed
@psykzz psykzz deleted the claude/fix-react-roles-type-inconsistency branch March 29, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [CRITICAL] Type inconsistency in react_roles causes reaction role removal to fail

2 participants