Add per-guild locking to prevent race conditions in concurrent config access#131
Draft
Add per-guild locking to prevent race conditions in concurrent config access#131
Conversation
Implement application-level locking using asyncio.Lock for all four affected cogs: - party: Lock party creation, editing, and user signup operations - secret_santa: Lock wishlist updates and event modifications - quotesdb: Lock quote addition and deletion operations - assign_roles: Lock role authorization/deauthorization with duplicate check Each cog now maintains per-guild locks to prevent concurrent config modifications from overwriting each other. This follows the same pattern used in albion_bandits. Agent-Logs-Url: https://github.com/psykzz/cogs/sessions/fcefea81-0cc1-4048-8aef-fb92d67b5155 Co-authored-by: psykzz <1134201+psykzz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple cogs had race conditions where concurrent async operations could overwrite each other's config changes. When two tasks read → modify → write simultaneously, the second write would silently drop the first task's changes.
Changes
party/party.py
secret_santa/secret_santa.py
quotesdb/quotedb.py
assign_roles/assign_roles.py
Implementation
Each cog now maintains a per-guild lock dictionary, following the pattern already used in
albion_bandits:Locks are per-guild to avoid blocking operations across different servers. Each cog's config is modified independently under lock protection.