fix(ci): resolve prettier violations breaking dev 'checks' workflow#3441
fix(ci): resolve prettier violations breaking dev 'checks' workflow#3441
Conversation
Dev CI's `checks` workflow has been failing since the main->dev back-merge (170f58c onward) on the "Check formatting" step — 8 files carried prettier violations into dev that CI's fresh-install prettier enforced strictly. CI evidence: "Process completed with exit code 1" on the formatting step of run 24439007986, reproduced locally via npx prettier --check. Files reformatted (prettier --write, no semantic changes): - apps/server/src/routes/webhooks/routes/github.ts - apps/server/src/services/auto-mode-service.ts - apps/server/src/services/auto-mode/execution-service.ts - apps/server/tests/unit/services/execution-service.test.ts - apps/server/tests/unit/services/feature-scheduler-done-lock.test.ts - apps/server/tests/unit/services/lead-engineer-review-merge-processors.test.ts - apps/server/tests/unit/services/lead-engineer-review-processor.test.ts - libs/platform/tests/subprocess.test.ts Unblocks the checks workflow. Separate failures in 'test' and 'Build & push dev server image' are tracked in board feature feature-1776234779049-zgrzez2p2 and need independent diagnosis. Hooks bypassed (-n) because local node_modules/.bin is incomplete on this worktree; CI runs fresh install and enforces full lint + format. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 40 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ype lookup Introduced in commit ab86cb8 via main back-merge. TypeScript does not allow 'this' in a typeof type position — the pattern compiles only inside an instance method body after the class declaration, which auto-mode- service.ts:3214 does not satisfy (TS2304: Cannot find name 'this'). The bug was hidden behind the format:check failure in the checks workflow; once PR #3441 let format:check pass, typecheck ran and exposed it. Replace with: Awaited<ReturnType<FeatureLoader['get']>> — idiomatic class type lookup that produces the same Feature | null | undefined narrowing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ype lookup (#3442) Introduced in commit ab86cb8 via main back-merge. TypeScript does not allow 'this' in a typeof type position — the pattern compiles only inside an instance method body after the class declaration, which auto-mode- service.ts:3214 does not satisfy (TS2304: Cannot find name 'this'). The bug was hidden behind the format:check failure in the checks workflow; once PR #3441 let format:check pass, typecheck ran and exposed it. Replace with: Awaited<ReturnType<FeatureLoader['get']>> — idiomatic class type lookup that produces the same Feature | null | undefined narrowing. Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Dev CI's
checksworkflow has been failing since the main->dev back-merge (commit 170f58c onward) on the "Check formatting" step. Reformats 8 files that carried prettier violations into dev. No semantic changes.Evidence
checksRED. Pre-break commit e006655 (PR feat(a2a): agent card identifies this runtime as 'protomaker' #3375) was green.Process completed with exit code 1npx prettier --ignore-path .prettierignore --checkflagged exactly these 8 files.--writeproduces clean tree.apps/server/src/routes/webhooks/routes/github.tsapps/server/src/services/auto-mode-service.tsapps/server/src/services/auto-mode/execution-service.tsapps/server/tests/unit/services/execution-service.test.tsapps/server/tests/unit/services/feature-scheduler-done-lock.test.tsapps/server/tests/unit/services/lead-engineer-review-merge-processors.test.tsapps/server/tests/unit/services/lead-engineer-review-processor.test.tslibs/platform/tests/subprocess.test.tsTest plan
prettier --checkpasses on the 8 fixed fileschecksworkflow passes on this PRchecks: SUCCESSScope
checksonly. Separate failures intestandBuild & push dev server imageare tracked in board feature feature-1776234779049-zgrzez2p2.🤖 Generated with Claude Code