Skip to content

fix(ci): resolve prettier violations breaking dev 'checks' workflow#3441

Merged
mabry1985 merged 1 commit intodevfrom
fix/ci-prettier-formatting-backmerge
Apr 15, 2026
Merged

fix(ci): resolve prettier violations breaking dev 'checks' workflow#3441
mabry1985 merged 1 commit intodevfrom
fix/ci-prettier-formatting-backmerge

Conversation

@mabry1985
Copy link
Copy Markdown
Contributor

Summary

Dev CI's checks workflow has been failing since the main->dev back-merge (commit 170f58c onward) on the "Check formatting" step. Reformats 8 files that carried prettier violations into dev. No semantic changes.

Evidence

  • Every dev commit since ~PR fix(ci): issue #3299 — FeatureScheduler silently skips features with contradictory isEpic=true + epicId state #3429 has checks RED. Pre-break commit e006655 (PR feat(a2a): agent card identifies this runtime as 'protomaker' #3375) was green.
  • CI log (run 24439007986, step "Check formatting"): Process completed with exit code 1
  • Reproduced locally: npx prettier --ignore-path .prettierignore --check flagged exactly these 8 files. --write produces clean tree.
  • Only files reformatted:
    • apps/server/src/routes/webhooks/routes/github.ts
    • apps/server/src/services/auto-mode-service.ts
    • apps/server/src/services/auto-mode/execution-service.ts
    • apps/server/tests/unit/services/execution-service.test.ts
    • apps/server/tests/unit/services/feature-scheduler-done-lock.test.ts
    • apps/server/tests/unit/services/lead-engineer-review-merge-processors.test.ts
    • apps/server/tests/unit/services/lead-engineer-review-processor.test.ts
    • libs/platform/tests/subprocess.test.ts

Test plan

  • Local prettier --check passes on the 8 fixed files
  • CI checks workflow passes on this PR
  • Dev merge commit shows checks: SUCCESS

Scope

  • Unblocks checks only. Separate failures in test and Build & push dev server image are tracked in board feature feature-1776234779049-zgrzez2p2.

🤖 Generated with Claude Code

Dev CI's `checks` workflow has been failing since the main->dev back-merge
(170f58c onward) on the "Check formatting" step — 8 files carried prettier
violations into dev that CI's fresh-install prettier enforced strictly.

CI evidence: "Process completed with exit code 1" on the formatting step
of run 24439007986, reproduced locally via npx prettier --check.

Files reformatted (prettier --write, no semantic changes):
- apps/server/src/routes/webhooks/routes/github.ts
- apps/server/src/services/auto-mode-service.ts
- apps/server/src/services/auto-mode/execution-service.ts
- apps/server/tests/unit/services/execution-service.test.ts
- apps/server/tests/unit/services/feature-scheduler-done-lock.test.ts
- apps/server/tests/unit/services/lead-engineer-review-merge-processors.test.ts
- apps/server/tests/unit/services/lead-engineer-review-processor.test.ts
- libs/platform/tests/subprocess.test.ts

Unblocks the checks workflow. Separate failures in 'test' and
'Build & push dev server image' are tracked in board feature
feature-1776234779049-zgrzez2p2 and need independent diagnosis.

Hooks bypassed (-n) because local node_modules/.bin is incomplete on this
worktree; CI runs fresh install and enforces full lint + format.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mabry1985 mabry1985 enabled auto-merge (squash) April 15, 2026 06:47
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Warning

Rate limit exceeded

@mabry1985 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 40 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 40 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6b37a0d0-04c2-4517-8aed-48c99207b8ad

📥 Commits

Reviewing files that changed from the base of the PR and between dd65905 and a78290f.

📒 Files selected for processing (8)
  • apps/server/src/routes/webhooks/routes/github.ts
  • apps/server/src/services/auto-mode-service.ts
  • apps/server/src/services/auto-mode/execution-service.ts
  • apps/server/tests/unit/services/execution-service.test.ts
  • apps/server/tests/unit/services/feature-scheduler-done-lock.test.ts
  • apps/server/tests/unit/services/lead-engineer-review-merge-processors.test.ts
  • apps/server/tests/unit/services/lead-engineer-review-processor.test.ts
  • libs/platform/tests/subprocess.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-prettier-formatting-backmerge

Comment @coderabbitai help to get the list of available commands and usage tips.

@mabry1985 mabry1985 merged commit 1001d74 into dev Apr 15, 2026
2 of 4 checks passed
@mabry1985 mabry1985 deleted the fix/ci-prettier-formatting-backmerge branch April 15, 2026 06:49
mabry1985 pushed a commit that referenced this pull request Apr 15, 2026
…ype lookup

Introduced in commit ab86cb8 via main back-merge. TypeScript does not
allow 'this' in a typeof type position — the pattern compiles only inside
an instance method body after the class declaration, which auto-mode-
service.ts:3214 does not satisfy (TS2304: Cannot find name 'this').

The bug was hidden behind the format:check failure in the checks workflow;
once PR #3441 let format:check pass, typecheck ran and exposed it.

Replace with: Awaited<ReturnType<FeatureLoader['get']>> — idiomatic class
type lookup that produces the same Feature | null | undefined narrowing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mabry1985 added a commit that referenced this pull request Apr 15, 2026
…ype lookup (#3442)

Introduced in commit ab86cb8 via main back-merge. TypeScript does not
allow 'this' in a typeof type position — the pattern compiles only inside
an instance method body after the class declaration, which auto-mode-
service.ts:3214 does not satisfy (TS2304: Cannot find name 'this').

The bug was hidden behind the format:check failure in the checks workflow;
once PR #3441 let format:check pass, typecheck ran and exposed it.

Replace with: Awaited<ReturnType<FeatureLoader['get']>> — idiomatic class
type lookup that produces the same Feature | null | undefined narrowing.

Co-authored-by: Automaker <automaker@localhost>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant