-
Notifications
You must be signed in to change notification settings - Fork 31
Add spiffe support proposal #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kfox1111
wants to merge
2
commits into
prometheus:main
Choose a base branch
from
kfox1111:spiffe-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| ## SPIFFE Support | ||
|
|
||
| * **Owners:** | ||
| * `kfox1111` | ||
|
|
||
| * **Implementation Status:** `Partially implemented` | ||
|
|
||
| * **Related Issues and PRs:** | ||
| * https://github.com/prometheus/exporter-toolkit/issues/259 | ||
| * https://github.com/prometheus/exporter-toolkit/pull/387 | ||
|
|
||
| > TL;DR: Flip a switch and exporters can mTLS with SPIFFE based identities | ||
|
|
||
| ## Why | ||
|
|
||
| TLS is hard and manual. mTLS is even harder. | ||
|
|
||
| SPIFFE and its corresponding reference implementation SPIRE makets it very easy to get fresh certificates in a fully automatic way. | ||
| Connections between prometheus and exporters can be two way validated and encrypted. | ||
|
|
||
| ### Pitfalls of the current solution | ||
|
|
||
| The main issue right now is the go-spiffe library pulls in otel and that pulls in a lot of dependencies. They compile out, but it looks bad. | ||
|
|
||
| ## Goals | ||
|
|
||
| Support easy configuration of prometheus and exporters | ||
|
|
||
| ### Audience | ||
|
|
||
| If not clear, the target audience that this change relates to. | ||
|
|
||
| ## Non-Goals | ||
|
|
||
| * Move old designs to the new format. | ||
| * Not doing X,Y,Z. | ||
|
|
||
| ## How | ||
|
|
||
| We add SPIFFE support to the exporter-toolkit and prometheus scrape configuration | ||
|
|
||
| ## Alternatives | ||
|
|
||
| Today you can wrap every exporter in a SPIFFE supporting proxy and put a proxy inbetween prometheus and the exporter too. It's painful. The idea is security should be easy. | ||
|
|
||
| ## Action Plan | ||
|
|
||
| The tasks to do in order to migrate to the new idea. | ||
|
|
||
| * [ ] Implement support in the exporter-toolkit | ||
| * [ ] Implement support in prometheus | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is from gRPC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see in prometheus/exporter-toolkit#387 the implicit dependencies it pulls in