Skip to content

feat: add shared wildcard detector package (dnsx#924 1/2)#732

Merged
Mzack9999 merged 4 commits intoprojectdiscovery:mainfrom
Veirt:refactor/extract-shuffledns-wildcard-resolver
Mar 20, 2026
Merged

feat: add shared wildcard detector package (dnsx#924 1/2)#732
Mzack9999 merged 4 commits intoprojectdiscovery:mainfrom
Veirt:refactor/extract-shuffledns-wildcard-resolver

Conversation

@Veirt
Copy link
Contributor

@Veirt Veirt commented Mar 20, 2026

Related to projectdiscovery/dnsx#924

Proposed changes

  • extract the shared wildcard detection core from shuffledns into utils/dns/wildcard
  • preserve the original wildcard permutation, cache flow, and explanatory comments from upstream while making lookups injectable for reuse across tools
  • add RegistrableRoot so consumers can group wildcard detection per registrable domain
  • add focused tests covering wildcard permutations, cache behavior, reprobes, current-host revalidation, transient probe errors, and registrable-root parsing

Proof

go test ./dns/wildcard -count=1

Output:

ok  	github.com/projectdiscovery/utils/dns/wildcard	0.008s

Checklist

  • Pull request is created against the correct base branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Veirt Veirt changed the title feat: add shared wildcard detector package (dnsx#924) feat: add shared wildcard detector package (dnsx#924 1/2) Mar 20, 2026
@Mzack9999 Mzack9999 merged commit ce6beb3 into projectdiscovery:main Mar 20, 2026
7 checks passed
@neo-by-projectdiscovery-dev
Copy link

neo-by-projectdiscovery-dev bot commented Mar 20, 2026

Neo - PR Security Review

No security issues found

Highlights

  • Adds shared wildcard detection package extracted from shuffledns with injectable DNS lookup mechanism
  • Implements registrable domain parsing using golang.org/x/net/publicsuffix for TLD handling
  • Includes comprehensive test coverage for wildcard permutations, caching, reprobing, and edge cases

Comment @pdneo help for available commands. · Open in Neo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants