Fix/dependabot bumps#751
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 63.58% 64.74% +1.16%
==========================================
Files 57 53 -4
Lines 5083 4601 -482
==========================================
- Hits 3232 2979 -253
+ Misses 1184 1024 -160
+ Partials 667 598 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
23121cd to
e82e7ce
Compare
This took way longer than I wanted. Two issues:
|
1ae968f to
c20d613
Compare
|
\o/ All these go deps are rather gnarly. A little surprised at the end here that not long were we dependent on umoci compress size (fixed since umoci 0.5.0) but it seems Will clean up these sets of commits tomorrow. Stacker at this point is squeezy clean via grype: |
|
|
6b5358e to
2f9c980
Compare
2f9c980 to
ab0a92a
Compare
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Re-add the Bom field in the Layer struct Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
fulcio bump requires: - move to go 1.25.8 - latest grpc 1.77.0 had issues with some undefined header so drop replace to 1.76.0 release Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Fix the remaining high CVE by bumping to modern incus v6 shared golang API for idmap support - reworked idmap struct member IDs and - carefully bump to storage v1.58.0 as our containers/images release v5.34.0 requires a containers/storage release 1.58.0 which is the last release before the API change of GetDiffer -> NewDiffer which breaks the storage_dest.go in the v5.34.0. Note this is only detectable via `make lint` as the stacker binary does not utilize the pkg/lib code; but we have downstream tools which do import this which may be affected. Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
The various tar.gz test fails when we move up, keep previous values: compress v1.18.0 mtree v0.5.4 Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Resolve the last few Medium CVEs by bumping sigstore deps: rekor v1.3.8 => v1.5.0 sigstore v1.10.0 => v1.10.4 fulcio v1.8.3 => v1.8.5 Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Some strange case where the workflow cached 1.25.7 and used 1.25.8 Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Detect when stacker.yaml has 'bom:' field set and print a warning that it is no longer supported. Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
ab0a92a to
7a9389e
Compare
mikemccracken
left a comment
There was a problem hiding this comment.
Looked again after your update, still lgtm. thanks for adding the WasBom check.
It looks like the docs dir here doesn't cover bom: at all, which was an oversight.
It is currently covered in the website docs at https://github.com/project-stacker/project-stacker.github.io/blob/main/docs/user_guide/generate_sbom.md?plain=1 - which I previously assumed were generated from the docs directory here. We should delete that when this merges.
What type of PR is this?
cleanup
Which issue does this PR fix:
#742
#734
#732
#730
#725
#724
#722
#708
#704
What does this PR do / Why do we need it:
Fix Critical/High/Medium CVEs against golang dependencies in stacker.
If an issue # is not available please add repro steps and logs showing the issue:
grype stacker
Testing done on this change:
make test priv and unpriv on amd64
Automation added to e2e:
none
Will this break upgrades or downgrades?
no
Does this PR introduce any user-facing change?:
Yes. Dropping stacker-bom support. The stacker-bom project is out-of-date with newer synk API which prevents updating it to newer go.mods which then keeps stacker down to be compatible with the stacker-bom go API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.