Skip to content

RHAIENG-1795: test using gateway config as fallback for constructing dashboard url #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kryanbeane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RHAIENG-1795: test using gateway config as fallback for constructing dashboard url #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/codeflare_sdk/ray/cluster/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,6 +1176,13 @@ def _get_dashboard_url_from_httproute(
Get the Ray dashboard URL from an HTTPRoute (RHOAI v3.0+ Gateway API).
Searches for HTTPRoute labeled with ray.io/cluster-name and ray.io/cluster-namespace.
Returns the dashboard URL if found, or None to allow fallback to Routes/Ingress.

Hostname resolution order:
1. Gateway spec.listeners[].hostname
2. OpenShift Route exposing the Gateway
3. GatewayConfig CR domain configuration (ODH/RHOAI)
4. Gateway status.addresses[].value

Args:
cluster_name: Ray cluster name
namespace: Ray cluster namespace
Expand Down Expand Up @@ -1283,6 +1290,29 @@ def _get_dashboard_url_from_httproute(
except Exception:
pass # Continue to next fallback

# If no hostname from Route, try GatewayConfig CR
if not hostname:
try:
# GatewayConfig is a cluster-scoped CR in services.platform.opendatahub.io
gateway_config = api_instance.get_cluster_custom_object(
group="services.platform.opendatahub.io",
version="v1alpha1",
plural="gatewayconfigs",
name="default",
)

# Extract subdomain (defaults to "data-science-gateway")
subdomain = gateway_config.get("spec", {}).get("subdomain", "").strip()
if not subdomain:
subdomain = "data-science-gateway"

# Extract domain from GatewayConfig
domain = gateway_config.get("spec", {}).get("domain", "").strip()
if domain:
hostname = f"{subdomain}.{domain}"
except Exception:
pass

# If still no hostname, try status.addresses (internal address - may only work in-cluster)
if not hostname:
addresses = gateway.get("status", {}).get("addresses", [])
Expand Down