Conversation
If we build Profanity without GTK we dont iterate the context so we will never know when the editor exited. Calling `g_main_context_iteration()` or finally switching to GMainLoop fixes this. So far calling `tray_update()` does this for us in GTK builds. So this went unnoticed. The editor will inherit ignored signal handlers (SIGINT, SIGTSTP, SIGPIPE) from us. Neovim uses libuv which seems to check SIGINT on startup to determine whether the environment is interactive or not. We now reset these signals to SIG_DFL in the child process before execvp. Profanity uses readline which still competed for terminal input with the editor. We only took care about other Profanity UI processes in our previous commit. This led to misordered characters in the editor. In my tests with vim everything worked fine and these bugs were discovered when a user used neovim. Fixes: #2148 Ref: 36ec2b0 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we build Profanity without GTK we dont iterate the context so we will never know when the editor exited. Calling
g_main_context_iteration()or finally switching to GMainLoop fixes this.So far calling
tray_update()does this for us in GTK builds. So this went unnoticed.The editor will inherit ignored signal handlers (SIGINT, SIGTSTP, SIGPIPE) from us. Neovim uses libuv which seems to check SIGINT on startup to determine whether the environment is interactive or not. We now reset these signals to SIG_DFL in the child process before execvp.
Profanity uses readline which still competed for terminal input with the editor. We only took care about other Profanity UI processes in our previous commit. This led to misordered characters in the editor.
In my tests with vim everything worked fine and these bugs were discovered when a user used neovim.
Fixes: #2148
Ref: 36ec2b0