Conversation
Contributor
|
This does seem to fix #2143, however the screen seems to not be redrawn after the pinentry closes causing interwoven output until |
Replace g_spawn_command_line_sync with g_spawn_sync with the G_SPAWN_CHILD_INHERITS_STDIN flag. This is actually needed to so that interactive commands can access the terminal. Otherwise they cannot ask the user for the passphrase. Ref: f5787fb Fixes: #2143 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Member
Author
|
Good catch. Please test again. |
Contributor
|
I'm afraid I'm still seeing interwoven output.
|
Member
Author
|
I'm using |
Member
Author
|
This task now turned into a whole quest :) |
Commit 81f92f1 introduced a selective update mechanism to _accounts_save() to prevent overwrites when running multiple instances by only modifying the specific account being saved. Commit 5c484c fixed a problem with that commit regarding empty accounts. It turns there was another bug introduced: The new implementation only set the keys that existed in memory. So removal of keys was not possible anymore. Fixes: 81f92f1 Ref: 5c484c2 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
There was way too much repetition here. This is in preparation for future changes regarding the editor. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Move from blocking fork/wait logic to nonblocking fork and g_child_watch_add. This ensures that the Profanity main loop continues to run while an external editor is open. So we don't loose connection and react to pings. We change editor handling also in vcard and muc subject editing. In the new implementation we are launching the editor and passing a callback which we will use once the editor exited. We use the recently added ui_susped() and ui_resume(). To not clutter the UI we need to check whether Profanity UI is suspended and omit drawing in this case. Fixes: #1888 Ref: 9b11290 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This was forgotten in a refactor commit. Ref: c43c956 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Remove IDE specific entries, they belong in the global conf of the user. Remove autotools specific files. Ref: bc777c5 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace g_spawn_command_line_sync with g_spawn_sync with the G_SPAWN_CHILD_INHERITS_STDIN flag.
This is actually needed to so that interactive commands can access the terminal.
Otherwise they cannot ask the user for the passphrase.
Ref: f5787fb