Open
Conversation
to put the test in the appropriate directory, id have to java files to grade build configs, because it currently only checks for kotlin tests.
create a temp zip file > create a destination that is a file not a directory (guaranteed exception) -> unzip throws ioexception because it expects a directory not a file -> catch it -> check if the zip file is still open -> if true == leak.
Ive also removed the test since its OS specific, and new code is supposed to be in kotlin.
Contributor
Author
|
Still pending work, just realized that i tradedoff the crash with the window not being undecorated, so ill be looking more into this. |
Moved the undecorated setup to the very beginning of the Editor constructor before any operations that could make the frame displayable happened.
Contributor
Author
The fix apparently was as simple as moving the linux check to the beginning of the constructor. it is now back to being properly undecorated + not crashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#1410
Solution
Conditional using isDisplayable().