Skip to content

correct the @After hook example#66

Open
capaj wants to merge 1 commit intoprismake:masterfrom
capaj:patch-2
Open

correct the @After hook example#66
capaj wants to merge 1 commit intoprismake:masterfrom
capaj:patch-2

Conversation

@capaj
Copy link
Copy Markdown
Contributor

@capaj capaj commented Apr 17, 2019

as it was before it was a bit confusing.

This example would have worked much better if the TODO left in code about passing the return value was implemented.
Then it could be something like:

image

as it was before it was a bit confusing
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2019

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          60       60           
  Lines         658      658           
  Branches       29       29           
=======================================
  Hits          600      600           
  Misses         56       56           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313c4b1...49384e9. Read the comment docs.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@313c4b1). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   91.18%           
=========================================
  Files             ?       60           
  Lines             ?      658           
  Branches          ?       29           
=========================================
  Hits              ?      600           
  Misses            ?       56           
  Partials          ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants