fix: stop infinite miles retry when commitment is never opened#913
Open
fix: stop infinite miles retry when commitment is never opened#913
Conversation
Contributor
|
Edge Case to Consider: Looking at insertEvent() in sweep.go (lines 125-162): Then blockTS stays nil, gets inserted as NULL, and the row will retry indefinitely without the 15-minute timeout. In Practice: Recent/mempool issues during indexing Recommendation:
Note: AI recommended |
passandscore
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When tx goes through fastrpc but the commitment is never opened (builder doesn't open for whatever reason), we were previously retrying indefinitely. This change stops retrying after 15 minutes and processes with a 0 bid cost since no bid payment was sent.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review