fix: set tag types for TOC properly in PDF exports#395
Open
greatislander wants to merge 2 commits intodevfrom
Open
fix: set tag types for TOC properly in PDF exports#395greatislander wants to merge 2 commits intodevfrom
greatislander wants to merge 2 commits intodevfrom
Conversation
|
@arzola Ned has asked for a review here, can you do that? It would fix an accessibility issue that a client reported. |
Contributor
|
I'll take a look to see if we can squeeze this in our current sprint(if not next sprint will be handled) |
Member
|
This looks terrific and just like what we need. Thanks @greatislander! |
Collaborator
Author
|
@arzola can we get a review of this? It ideally should have been in that release. |
|
sub-issue addressed by this fix: https://github.com/pressbooks/private/issues/2392 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pressbooks/private#2099.
To test:
pressbooks-book/packages/buckram.