Skip to content

fix: Allow arbitrary CRs in update-claims-features module#335

Merged
juanjosevazquezgil merged 52 commits intomainfrom
fix/334-allow-arbitrary-crs
Apr 21, 2026
Merged

fix: Allow arbitrary CRs in update-claims-features module#335
juanjosevazquezgil merged 52 commits intomainfrom
fix/334-allow-arbitrary-crs

Conversation

@juanjosevazquezgil
Copy link
Copy Markdown
Contributor

@juanjosevazquezgil juanjosevazquezgil commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

update-claims-features/go.mod:3

  • go 1.25.0 is likely not a released Go toolchain version yet, which can break builds in CI/tooling that expects an available version. Use the project’s supported Go version (or the latest released Go version) instead of a future version number.
go 1.23.6

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread update-claims-features/utils.go Outdated
Comment thread update-claims-features/claims.go Outdated
Comment thread update-claims-features/claims.go Outdated
Comment thread update-claims-features/main.go Outdated
Comment thread update-claims-features/utils.go
Comment thread update-claims-features/utils.go Outdated
Comment thread update-claims-features/utils.go Outdated
Comment thread update-claims-features/claims.go Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

update-claims-features/utils.go:203

  • yamlEncoder.Encode(&claim) is called without checking the returned error, and the encoder is never closed. Please handle the Encode error and call yamlEncoder.Close() (and handle its error) to avoid silently producing incomplete/invalid YAML when encoding fails.
	var buffer bytes.Buffer
	yamlEncoder := yaml.NewEncoder(&buffer)
	yamlEncoder.SetIndent(2)
	yamlEncoder.Encode(&claim)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread update-claims-features/claims.go Outdated
Comment thread update-claims-features/claims.go
Comment thread update-claims-features/claims.go
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread update-claims-features/claims.go
Comment thread update-claims-features/github.go Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@juanjosevazquezgil juanjosevazquezgil merged commit db9d855 into main Apr 21, 2026
1 check passed
@juanjosevazquezgil juanjosevazquezgil deleted the fix/334-allow-arbitrary-crs branch April 21, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[update-claims-features] Fix the process removing new claim fields

3 participants