fix: Allow arbitrary CRs in update-claims-features module#335
fix: Allow arbitrary CRs in update-claims-features module#335juanjosevazquezgil merged 52 commits intomainfrom
Conversation
…app/daggerverse into fix/334-allow-arbitrary-crs
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
Comments suppressed due to low confidence (1)
update-claims-features/go.mod:3
go 1.25.0is likely not a released Go toolchain version yet, which can break builds in CI/tooling that expects an available version. Use the project’s supported Go version (or the latest released Go version) instead of a future version number.
go 1.23.6
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
update-claims-features/utils.go:203
yamlEncoder.Encode(&claim)is called without checking the returned error, and the encoder is never closed. Please handle theEncodeerror and callyamlEncoder.Close()(and handle its error) to avoid silently producing incomplete/invalid YAML when encoding fails.
var buffer bytes.Buffer
yamlEncoder := yaml.NewEncoder(&buffer)
yamlEncoder.SetIndent(2)
yamlEncoder.Encode(&claim)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #334
topicsfield was deleted): https://github.com/jvazquez-prefapp/claims/actions/runs/24721827421 -> https://github.com/jvazquez-prefapp/claims/pull/115