Skip to content

Fix release workflow tag-version check by exporting TAG_VERSION #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
espenhgn merged 3 commits into from
Apr 21, 2026
Merged

Fix release workflow tag-version check by exporting TAG_VERSION #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d989ae
Initial plan
Copilot Apr 21, 2026
25028a8
fix: export TAG_VERSION in release workflow version check
Copilot Apr 21, 2026
53a1514
Increment patch version from 1 to 2
espenhgn Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

- name: Check version matches tag
run: |
TAG_VERSION="${GITHUB_REF_NAME#v}"
export TAG_VERSION="${GITHUB_REF_NAME#v}"
python - <<'PY'
import pathlib
import os
Expand Down
1 change: 1 addition & 0 deletions tests/test_release_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def test_release_workflow_checks_tag_commit_is_on_main():

def test_release_workflow_checks_version_and_generates_notes():
content = WORKFLOW_FILE.read_text()
assert 'export TAG_VERSION="${GITHUB_REF_NAME#v}"' in content
assert 'version/version.py' in content
assert 'VERSION' in content
assert 'softprops/action-gh-release@v2' in content
Expand Down
4 changes: 2 additions & 2 deletions version/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
_MINOR = "1"
# On main and in a nightly release the patch should be one ahead of the last
# released build.
_PATCH = "1"
_PATCH = "2"
# This is mainly for nightly builds which have the suffix ".dev$DATE". See
# https://semver.org/#is-v123-a-semantic-version for the semantics.
_SUFFIX = ""

VERSION_SHORT = "{0}.{1}".format(_MAJOR, _MINOR)
VERSION = "{0}.{1}.{2}{3}".format(_MAJOR, _MINOR, _PATCH, _SUFFIX)
VERSION = "{0}.{1}.{2}{3}".format(_MAJOR, _MINOR, _PATCH, _SUFFIX)
Loading