Skip to content

Add ARM builds#56

Merged
espenhgn merged 7 commits into
mainfrom
espenhgn/issue54
Apr 21, 2026
Merged

Add ARM builds#56
espenhgn merged 7 commits into
mainfrom
espenhgn/issue54

Conversation

@espenhgn
Copy link
Copy Markdown
Collaborator

@espenhgn espenhgn commented Oct 8, 2024

Fixes #54

Changes proposed in this pull request:

  • Add Docker builds for linux/arm64 platform (support recent Macs)

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn added the enhancement New feature or request label Oct 8, 2024
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds multi-architecture container builds to publish linux/arm64 images (in addition to linux/amd64) to better support ARM-based developer machines (e.g., Apple Silicon).

Changes:

  • Enable multi-platform Docker builds/pushes for linux/amd64 and linux/arm64.
  • Adjust Docker image tagging rules generated by docker/metadata-action.
  • Bump the template version patch number.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
version/version.py Bumps patch version (0.1.00.1.1).
.github/workflows/container_build_push.yml Publishes multi-arch Docker images and adjusts tag generation.
.github/workflows/container_build.yml Builds (including in PR CI) for both amd64/arm64 and adjusts tag generation.

Comment thread .github/workflows/container_build.yml Outdated
Comment thread .github/workflows/container_build.yml
Comment thread .github/workflows/container_build.yml Outdated
Comment thread .github/workflows/container_build_push.yml
Comment thread .github/workflows/container_build_push.yml
Comment thread .github/workflows/container_build.yml
@espenhgn
Copy link
Copy Markdown
Collaborator Author

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

@copilot apply changes based on the comments in this thread

Applied in commit 8794b49. I updated the workflow files to restore type=semver,pattern={{major}}, fixed multi-platform build usage with load in container_build.yml (single-platform for the loaded test image, multi-platform build without load), and normalized the multi-platform list formatting where needed. No UI changes were made (workflow-only change), so there is no UI screenshot to provide.

@espenhgn espenhgn merged commit bae44d1 into main Apr 21, 2026
7 checks passed
@espenhgn espenhgn deleted the espenhgn/issue54 branch April 21, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ARM builds

3 participants