Skip to content

Test: Configuration for account logs warning#4410

Open
marki1an wants to merge 2 commits intoreplace-static-sampling-with-configured-ratefrom
tests/add-configuration-for-logs-warning-account
Open

Test: Configuration for account logs warning#4410
marki1an wants to merge 2 commits intoreplace-static-sampling-with-configured-ratefrom
tests/add-configuration-for-logs-warning-account

Conversation

@marki1an
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an added the tests Functional or other tests label Feb 27, 2026
@marki1an marki1an self-assigned this Feb 27, 2026
@marki1an marki1an requested a review from osulzhenko February 27, 2026 09:47

and: "PBs shouldn't emit warning logs"
def logsByTime = pbsService.getLogsByTime(start)
assert !getLogsByText(logsByTime, warningMessage)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add container cleanup for both tests

@marki1an marki1an requested a review from osulzhenko February 27, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Functional or other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants