Skip to content

test: fix deep equal ...again #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prawirdani merged 1 commit into from
Jul 4, 2025
Merged

test: fix deep equal ...again #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 8 additions & 26 deletions parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ type (

float32Alias float32
float64Alias float64

timeAlias time.Time
)

func TestStrings(t *testing.T) {
Expand Down Expand Up @@ -466,36 +464,23 @@ func TestFloats(t *testing.T) {

func TestTime(t *testing.T) {
type times struct {
F1 time.Time `qp:"f1"`
F2 *time.Time `qp:"f2"`
F3 timeAlias `qp:"f3"`
F4 *timeAlias `qp:"f4"`
F5 time.Time `qp:"-"`
F6 []time.Time `qp:"f6"`
F1 time.Time `qp:"f1"`
F2 *time.Time `qp:"f2"`
F3 time.Time `qp:"-"`
}

currDate := time.Now().Truncate(time.Nanosecond)

dateStr := currDate.Format(time.RFC3339Nano)
queryParams := fmt.Sprintf(
"f1=%s&f2=%s&f3=%s&f4=%s&f5=ignored&f6=%s,%s",
dateStr,
dateStr,
dateStr,
dateStr,
"f1=%s&f2=%s&f3=ignored",
dateStr,
dateStr,
)
expected := times{
F1: currDate,
F2: ptr(currDate),
F3: timeAlias(currDate),
F4: ptr(timeAlias(currDate)),
F5: time.Time{},
F6: []time.Time{
currDate,
currDate,
},
F3: time.Time{},
}

values, err := url.ParseQuery(queryParams)
Expand All @@ -505,12 +490,9 @@ func TestTime(t *testing.T) {
err = parse(values, &result)

require.Nil(t, err)
require.Equal(t, expected.F1, result.F1)
require.Equal(t, expected.F2, result.F2)
require.Equal(t, expected.F3, result.F3)
require.Equal(t, expected.F4, result.F4)
require.Equal(t, expected.F5, result.F5)
require.Equal(t, expected.F6, result.F6)
require.True(t, expected.F1.Equal(result.F1))
require.True(t, expected.F2.Equal(*result.F2))
require.True(t, expected.F3.Equal(result.F3))

t.Run("Invalid", func(t *testing.T) {
queryParams := "f1=invalid-date"
Expand Down