fix rows vector according to pyimagesearch python source code#7
Open
arashrahmani wants to merge 3 commits intoprat96:masterfrom
Open
fix rows vector according to pyimagesearch python source code#7arashrahmani wants to merge 3 commits intoprat96:masterfrom
arashrahmani wants to merge 3 commits intoprat96:masterfrom
Conversation
…e distances section of centroidtracker.cpp
…on to sort temp_rows elements according to their second element and put them in sorted order in rows vector (as it is implemented in pyimagesearch python code like this: rows = D.min(axis=1).argsort())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementation of rows vector was not like the PyimageSearch article (it was incomplete) and if you test the previous version of code on multiple objects you can see that it has some bugs.
the python code is as follows:
rows = D.min(axis=1).argsort()
the rows vector is calculated in sorted order of arguments based on the values of the D matrix. so I used sortbyfirst function (in C++) instead of numpy.min to get the minimum distance in axis1 and a for loop that gives the second attribute of each pair(arguments) of the sorted D instead of argsort.