DxiLValidation variable capitalization coding standards#9
Closed
pow2clk wants to merge 1 commit intonvec_ldst_prfrom
Closed
DxiLValidation variable capitalization coding standards#9pow2clk wants to merge 1 commit intonvec_ldst_prfrom
pow2clk wants to merge 1 commit intonvec_ldst_prfrom
Conversation
Capitalize all the variables and rename a few in DxilValidation.cpp in keeping with https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly As this file was easily mistaken for applying to the golden rule: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly it is at serious risk of receiving changes that will get hung up by requirements to follow the LLVM coding guidelines. This brings the cases where variable capitalization is not in line with the coding standards to avoid such pitfalls in the future.
You can test this locally with the following command:git-clang-format --diff 048f18e896a4817e8b895861cc171872d4f6815c 415e3a9f069809663e8fd267da689dbc91130d8f -- lib/DxilValidation/DxilValidation.cppView the diff from clang-format here.diff --git a/lib/DxilValidation/DxilValidation.cpp b/lib/DxilValidation/DxilValidation.cpp
index 8fa89dcb..f25208e7 100644
--- a/lib/DxilValidation/DxilValidation.cpp
+++ b/lib/DxilValidation/DxilValidation.cpp
@@ -4269,7 +4269,7 @@ static void ValidateSignatureElement(DxilSignatureElement &SE,
case DXIL::SemanticKind::DomainLocation:
case DXIL::SemanticKind::Invalid:
DXASSERT(!AllowedInSig, "else internal inconsistency between semantic "
- "interpretation table and validation code");
+ "interpretation table and validation code");
break;
case DXIL::SemanticKind::Barycentrics:
IsBarycentric = true;
|
pow2clk
pushed a commit
that referenced
this pull request
Mar 26, 2026
… `vk::SampledTexture2DMSArray` type (microsoft#8209) Part of microsoft#7979 `vk::SampledTexture2DMS` and `vk::SampledTexture2DMSArray`. The function definition is exactly the same as that of Texture2DMS and Texture2DMSArray, which do not take a sampler argument. Added a new test for `GetSamplePosition()` and `sample[][]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capitalize all the variables and rename a few in DxilValidation.cpp in keeping with https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
As this file was easily mistaken for applying to the golden rule: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly it is at serious risk of receiving changes that will get hung up by requirements to follow the LLVM coding guidelines. This brings the cases where variable capitalization is not in line with the coding standards to avoid such pitfalls in the future.