Skip to content

fix: avoid 5s timeout when revealing plotly widgets #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 1 commit into from
May 6, 2026
Merged

fix: avoid 5s timeout when revealing plotly widgets #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions js/src/plotly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ export async function waitForPlotlyReadyToReveal(
}

function waitForPlotlyAfterPlot(plotEl: HTMLElement): Promise<void> {
// If Plotly has already completed its render, _fullLayout will be populated.
// This avoids waiting for an event that already fired before we subscribed.
if ((plotEl as any)._fullLayout) {
return Promise.resolve();
}

return new Promise((resolve) => {
const handler = () => {
cleanup();
Expand Down
2 changes: 1 addition & 1 deletion shinywidgets/static/output.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading