Conversation
- add linear gradient - delete border
L1s-is
reviewed
Jun 21, 2024
L1s-is
left a comment
L1s-is
left a comment
There was a problem hiding this comment.
Все отлично, не забываем про использование БЭМ и просмотр верстки на адаптиве
| <link rel="stylesheet" href="/progress-bar/styles.css" /> | ||
| </head> | ||
| <body> | ||
| <div class="progress-bar"> |
There was a problem hiding this comment.
Стоило добавить какой-то контейнер, которому задать отступы, чтобы на адаптиве контент не прилипал к краям https://imgur.com/080HzFT
P.S. Да и в целом центрирование лучше делать не с помощью накладывания стилей на body, а создавать для этого специальный контейнер-обертку.
Ну и именование по бему для progress стоило сделать как Э - элемент, т.е. progress-bar__progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple animated progress bar was created using HTML and CSS. The
.progress-barelement is a container with certain sizes and styles, including a shadow and a rounding radius. The.progresselement represents the progress bar itself, which starts at zero width and animates to 100% when the cursor hovers over the.progress-bar.