Skip to content

fix(stripe): Remove redundant refund guard #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sashko9807 merged 2 commits into from
Apr 10, 2026
Merged

fix(stripe): Remove redundant refund guard #730

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7f6d2d
fix(stripe): Remove redundant refund guard
sashko9807 Apr 10, 2026
391ad02
Merge branch 'master' into fix/remove-redundant-refund-guard
sashko9807 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/api/src/stripe/stripe.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ export class StripeService {
},
{ idempotencyKey: `${idempotencyKey}--subscription` },
)
//include metadata in payment-intent
// In API version 2025-03-31+, invoices have a 'payments' array instead of direct payment_intent field
const invoice = subscription.latest_invoice as InvoiceWithPayments

Expand Down Expand Up @@ -475,10 +474,6 @@ export class StripeService {
throw new BadRequestException('Payment Intent is missing from stripe')
}

if (!intent.metadata.campaignId) {
throw new BadRequestException('Campaign id is missing from payment intent metadata')
}

return await this.api.createRefund({
payment_intent: paymentIntentId,
reason: 'requested_by_customer',
Expand Down
Loading