fix: update DB immediately on subscription cancellation#726
Merged
apetkov98 merged 1 commit intopodkrepi-bg:masterfrom Apr 1, 2026
Merged
Conversation
The cancel method had inverted logic — it treated a successful Stripe cancellation (status: 'canceled') as a failure, returning null without updating the DB record. The status was only corrected later when Stripe sent the webhook. Fix by updating the DB immediately after Stripe confirms cancellation. Also adds idempotency guards for already-canceled subscriptions, fixes missing awaits on webhook handlers that silently swallowed errors, and makes updateStatus resilient to concurrent cancel/webhook race conditions via a NOT filter with P2025 fallbackk
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
apetkov98
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cancel method had inverted logic — it treated a successful Stripe cancellation (status: 'canceled') as a failure, returning null without updating the DB record. The status was only corrected later when Stripe sent the webhook. Fix by updating the DB immediately after Stripe confirms cancellation.
Also adds idempotency guards for already-canceled subscriptions, fixes missing awaits on webhook handlers that silently swallowed errors, and makes updateStatus resilient to concurrent cancel/webhook race conditions via a NOT filter with P2025 fallback