Adds command outlook calendargroup remove. Closes #7112#7186
Open
MathijsVerbeeck wants to merge 3 commits intopnp:mainfrom
Open
Adds command outlook calendargroup remove. Closes #7112#7186MathijsVerbeeck wants to merge 3 commits intopnp:mainfrom
outlook calendargroup remove. Closes #7112#7186MathijsVerbeeck wants to merge 3 commits intopnp:mainfrom
Conversation
Adam-it
requested changes
Apr 7, 2026
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
@MathijsVerbeeck awesome work so far.
Lets be sure we reuse the calendar group util and cover the scenario when more then one time will be retrieved with same name and we should be ready to merge.
Checked locally ✅
src/m365/outlook/commands/calendargroup/calendargroup-remove.ts
Outdated
Show resolved
Hide resolved
src/m365/outlook/commands/calendargroup/calendargroup-remove.ts
Outdated
Show resolved
Hide resolved
MathijsVerbeeck
force-pushed
the
add-outlook-calendargroup-remove
branch
from
ac9c194 to
b778640
Compare
Contributor
Author
|
Hi @Adam-it Thanks for the feedback. |
Adam-it
requested changes
Apr 9, 2026
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
A lot better now but we introduced one bug along the way which we should fixup before we proceed
MathijsVerbeeck
force-pushed
the
add-outlook-calendargroup-remove
branch
from
b778640 to
6c776ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7112