Changes the signature of spfx rules to accepts object as args. Closes #7067

[waldekmastykarz]

Changes the signature of spfx rules to accepts object as args. Closes #7067

[Copilot]

Pull request overview

This PR refactors the constructor signatures of SPFx upgrade and doctor rules to accept object parameters instead of individual arguments, improving code maintainability and flexibility.

Changes:

• Updated base rule classes (DependencyRule, ResolutionRule, PackageRule, FileAddRemoveRule) to accept configuration objects
• Modified all derived rule classes to use the new object-based constructor pattern
• Updated test files and doctor configuration files to instantiate rules with object parameters

Reviewed changes

Copilot reviewed 300 out of 346 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/m365/spfx/commands/project/project-upgrade/rules/DependencyRule.ts	Introduced DependencyRuleOptions interface and refactored constructor to accept options object
src/m365/spfx/commands/project/project-upgrade/rules/ResolutionRule.ts	Changed constructor to accept object with packageName and packageVersion properties
src/m365/spfx/commands/project/project-upgrade/rules/PackageRule.ts	Updated constructor to accept object with propertyName, add, and optional propertyValue
src/m365/spfx/commands/project/project-upgrade/rules/FileAddRemoveRule.ts	Modified constructor to accept object with filePath, add, and optional contents
src/m365/spfx/commands/project/project-doctor/rules/DependencyRule.ts	Introduced DependencyRuleOptions interface with packageName, supportedRange, and optional isDevDep
Multiple FN*.ts files	Updated rule instantiation to use object parameters with spread syntax where applicable
Multiple spec files	Updated test instantiation to use object-based constructor calls
Multiple doctor-*.ts files	Updated rule instantiation in doctor configurations to use object parameters

Comments suppressed due to low confidence (2)

src/m365/spfx/commands/project/project-doctor/doctor-1.22.0.ts:1

• The property name should be supportedRange not packageVersion based on the FN002021_DEVDEP_rushstack_eslint_config constructor signature which expects { supportedRange: string }.
  src/m365/spfx/commands/project/project-doctor/doctor-1.21.0.ts:1
• The property name should be supportedRange not packageVersion based on the FN002021_DEVDEP_rushstack_eslint_config constructor signature which expects { supportedRange: string }.

[Jwaegebaert]

Nice job with this one. Nothing further but the feedback Copilot provided. Be sure to take a look at the remarks left by Copilot

[Jwaegebaert]

@waldekmastykarz, seems like the build is failing. Could you take a look at that?