Fix: Improve <Html> functional purity#54
Open
cadenceblorbo wants to merge 3 commits intopmndrs:mainfrom
Open
Conversation
-Change UseEffect to UseLayoutEffect -Move root creation into UseLayoutEffect -Small syntax/depreciated fixes
cadenceblorbo
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
cadenceblorbo
changed the title
cadenceblorbo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when using React's <StrictMode>, ReactDOM.createRoot() is called twice on the same root. This indicates an issue with functional purity. In addition, when <A11y> components are removed from the React tree, updates to the removed root may be attempted.
These changes are based on the most up-to-date drei Html component, and are likely to fix Issue 53.
Change UseEffect to UseLayoutEffect:
Move root creation into UseLayoutEffect and store root using useRef():
Small syntax/depreciated changes:
Adds type prefix to Assign import.EDIT: the type keyword was removed and the value passed into root's useRef() was changed to null! in order to support the software running on CodeSandbox.