Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to decrease default multisampling value to 2. Even on the modern GPU such high value as 8 is too much, especially if the target resolution is 2k or 4k. Modern displays have a higher pixel density than before so antialiasing is not needed as much as before. Also x8 antialiasing was an overkill even on older displays, x2 was fine and x4 was just right in my opinion.
Having x8 antialiasing by default just cause spikes on the framerate and loading GPU without notifying the client, it is a noticeable performance issue that may spend a lot of time to investigate for developers.
Me personally faced that issue twice. When I faced the framerate spikes for the second time even having the knowledge on the bottom of my head I naturally blamed postprocessing filters itself, not the composer, the issue was annoying but not critical so when I finally found the root cause I have a thought that I might be not alone. So that's the reason why I created this PR.