Restrict worker follow-up artifact writes#98
Merged
pmbstyle merged 2 commits intoMay 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fs_writeagainst arbitrary workspace-relative paths based on untrusted worker output, allowing overwrites of sensitive workspace files.Description
fs_writeonly for paths under the durable roots (reports/andartifacts/).ctxincludesworkspace_root,allowed_paths=list(_DURABLE_WORKSPACE_ROOTS), andrestrict_to_allowed_paths=Truewhen resolving follow-up tool calls._FilesystemPathshelper and arestrict_to_allowed_pathsflag in_resolve_tool_pathso callers can force enforcement ofallowed_pathschecks.fs_writeunder a restricted context can write toreports/but is blocked from overwriting sensitive workspace files, and a test that the follow-up tool context is configured with the restricted paths.Testing
uv run ruff checkwhich passed for the modified files.uv run black --checkwhich passed for the changed files.uv run pythonsmall scripts that exercisedfs_writeunder a restricted context and exercised_get_worker_followup_tools, confirming allowed writes succeed and disallowed writes are blocked.uv run python -m pytestfor the new tests but pytest could not be executed in the current environment becausepytestis not installed in the active venv and dev-dependency installation was blocked by network/package fetch errors.Codex Task