Block direct exec tool for Octo#100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
exec_runshell tool directly as part of its active tool set to reduce risk of arbitrary host command execution.exec_runin Octo's active tool set.Description
octo.direct_exec_denylistthat deniesexec_runto_get_octo_toolsinsrc/octopal/runtime/octo/router.pysoexec_runis removed from Octo's available tools by default.octo.direct_exec_denylistto CLI resolution via_octo_tool_policy_stepsinsrc/octopal/cli/main.pyto keep the CLI snapshot consistent with runtime policy.tests/test_octo_tool_loop.py,tests/test_router_tool_budget.py, andtests/test_cli_tools_resolve.pyto assertexec_runis not present in Octo active tools and that attemptedexec_runcalls return a policy block.Testing
uv run ruff check ...which passed after an automated import reordering fix.PYTHONPATH="src:.venv/lib/python3.14/site-packages" pytest ...for the modified tests and observed the targeted suite pass (4 passed, 20 warnings).uv run python -m compileall src/octopal ...which completed successfully.uv sync --extra devanduv pip install pytest pytest-asyncio, but these failed due to PyPI tunnel/network errors in the environment and did not block the targeted validations.Codex Task