Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
11e53e4
Add plus_pair_request function
bouwew Feb 2, 2026
f424d10
Document pairing process
bouwew Feb 7, 2026
7dc10b2
Add 0001-0002 req-resp-pair
bouwew Feb 7, 2026
1ad34ac
Add init stick
bouwew Feb 7, 2026
f86e92d
Improve docstring
bouwew Feb 7, 2026
92fb285
Improve pair_plus_device()
bouwew Feb 7, 2026
d4d27bd
Add todo for maybe needed functionality
bouwew Feb 7, 2026
109f82c
Fix typos, return type
bouwew Feb 7, 2026
95f35cd
Correct imports, improve docstring
bouwew Feb 7, 2026
7691865
Ruff fixes
bouwew Feb 7, 2026
f087b52
Make sure the Stick is ready to pair, as suggested
bouwew Feb 8, 2026
449c1f7
Fix spelling
bouwew Feb 8, 2026
f998029
Remove quotes, move
bouwew Feb 8, 2026
5534094
Set output as bool and use
bouwew Feb 8, 2026
697bf2d
Add missing await
bouwew Feb 8, 2026
3778359
Add 0003 response to docstring
bouwew Feb 8, 2026
981956b
Start adding pairing test
bouwew Feb 8, 2026
88a376a
Add missing connected()
bouwew Feb 8, 2026
92e96d1
Add pairing-test
bouwew Feb 8, 2026
4358717
Link to stick_pair_data
bouwew Feb 8, 2026
2d6a42a
Fix stick_pair_data
bouwew Feb 8, 2026
009b2f5
Set network to offline
bouwew Feb 8, 2026
b3186a0
Try
bouwew Feb 8, 2026
3996063
Try 2
bouwew Feb 8, 2026
37da15c
Try 3
bouwew Feb 8, 2026
1ee8cad
Add StickInitShortResponse
bouwew Feb 8, 2026
d8bb79f
Remove commented-out in response
bouwew Feb 8, 2026
a66224d
Update length
bouwew Feb 8, 2026
072b931
Adapt StickInitRequest send()
bouwew Feb 8, 2026
fd000f0
Update length StickInitResponse
bouwew Feb 8, 2026
d025f28
Clean up
bouwew Feb 8, 2026
b64b08f
Full test-output - test_pairing
bouwew Feb 8, 2026
646f284
Allow init to fail
bouwew Feb 8, 2026
5b2f717
Add sleep
bouwew Feb 8, 2026
37d3dde
Call pair_plus_request()
bouwew Feb 8, 2026
79e50ba
Connected and initialized is not required
bouwew Feb 8, 2026
3a907d3
fixup: pair-plus Python code fixed using Ruff
Feb 8, 2026
35a71bc
There can only be one response
bouwew Feb 8, 2026
acda9ca
Use inheritance for StickInitResponse
bouwew Feb 8, 2026
4473519
Move pair_plus_device() to connection
bouwew Feb 8, 2026
e39548c
Correct plus-mac
bouwew Feb 8, 2026
6f0207a
Add stick-mac to 0002 response
bouwew Feb 8, 2026
8d9e628
Move RESPONSE_MESSAGES
bouwew Feb 9, 2026
97a2314
Don't test network down first
bouwew Feb 9, 2026
07b5141
Add missing import
bouwew Feb 9, 2026
e066c18
Connect first
bouwew Feb 9, 2026
4c1c781
Try
bouwew Feb 9, 2026
4293dd1
fixup: pair-plus Python code fixed using Ruff
Feb 9, 2026
a852004
Try 3
bouwew Feb 10, 2026
0771bb9
Try 4
bouwew Feb 10, 2026
f1e353b
Try not allowed
bouwew Feb 10, 2026
e1d19d9
Extra bit
bouwew Feb 10, 2026
0bd75ef
CirclePlusConnectReqyest: shorter args
bouwew Feb 10, 2026
35e17e9
fixup: pair-plus Python code fixed using Ruff
Feb 10, 2026
9730f09
Add stick-mac to 0005-response, remove extra bit
bouwew Feb 10, 2026
41041fe
Ruffed
bouwew Feb 10, 2026
376e3cf
Shorten args, must be length=16
bouwew Feb 10, 2026
c2c5bbb
Add missing CRC, can be corrected later
bouwew Feb 10, 2026
dcbd167
Try
bouwew Feb 12, 2026
d7a3881
Try 2
bouwew Feb 13, 2026
f2d708b
Fixes
bouwew Feb 13, 2026
d431b5b
Correct CRC
bouwew Feb 13, 2026
efd2566
Try allowed
bouwew Feb 13, 2026
a6672a4
Change to Circle+ mac in 0005-response
bouwew Feb 13, 2026
c487e7d
Ruff-cleanup
bouwew Feb 13, 2026
8617f43
Bump to v0.48.0a1 test-version
bouwew Feb 13, 2026
6c74d55
Update CHANGELOG
bouwew Feb 13, 2026
07f60cb
Implement StickInitShortResponse-handling in class StickController
bouwew Feb 16, 2026
50e523d
Back to full test-output
bouwew Feb 16, 2026
11a9716
Improve
bouwew Feb 16, 2026
777cff2
Correct CHANGELOG after rebase
bouwew Feb 16, 2026
e3603bb
Bump to v0.48.0a2 test-version
bouwew Feb 16, 2026
4d863f9
Run all test-files in case of failure
bouwew Feb 16, 2026
e016bc1
Revert back to python 3.13
bouwew Feb 17, 2026
1ff71e0
Bump to a3
bouwew Feb 17, 2026
82bbc0b
Try-except stick-initialize
bouwew Feb 17, 2026
ca124b8
Ruff fix
bouwew Feb 17, 2026
8ac92e7
Add log-warning
bouwew Feb 17, 2026
23bf121
Bump to a4
bouwew Feb 17, 2026
7e35c9d
Remove is_connected requirement for mac_stick
bouwew Feb 18, 2026
1e0b080
Bump to a5
bouwew Feb 18, 2026
ae92adc
Disable now invalid test
bouwew Feb 18, 2026
8b0b2ff
More debug-logging
bouwew Feb 19, 2026
ffe2660
Bump to a6
bouwew Feb 19, 2026
0d07f50
Move debug message
bouwew Feb 19, 2026
ba959a0
Bump to a7
bouwew Feb 19, 2026
3ea75cc
Revert adding try-except
bouwew Feb 19, 2026
f6ae348
Replace debuggers by distinct message
bouwew Feb 20, 2026
0367476
Bump to a8
bouwew Feb 20, 2026
ed69b8e
Remove unneeded StickError raises
bouwew Feb 20, 2026
4023afa
Update relevant test-asserts
bouwew Feb 20, 2026
8dd5ccb
Ruff fixes
bouwew Feb 20, 2026
e8ca6e6
Correct -update test_stick_network_down()
bouwew Feb 20, 2026
c9eeb1b
Fix pylint warnings
bouwew Feb 20, 2026
fbb5cbf
More adapting to StickInitShortResponse
bouwew Feb 20, 2026
e1da552
Bump to a9
bouwew Feb 20, 2026
a686f87
Update Stick properties mac_stick, mac_coordinator and name
bouwew Feb 20, 2026
cc5aa9d
Update docstring
bouwew Feb 20, 2026
6e4defa
Update network_online docstring
bouwew Feb 20, 2026
a8ed69f
Bump to a10
bouwew Feb 20, 2026
eb25b73
fixup: pair-plus Python code fixed using Ruff
Feb 20, 2026
23f1327
Responses: line up Int() use
bouwew Feb 23, 2026
1e122f8
Add missing decode_mac=False
bouwew Feb 23, 2026
71319cb
Correct 0002-format in response
bouwew Feb 23, 2026
bb7b0fa
Bump to a11
bouwew Feb 23, 2026
757f7e8
Exit when network is not online
bouwew Feb 23, 2026
e66cd03
Bump to a12
bouwew Feb 23, 2026
880cd25
Revert "Exit when network is not online"
bouwew Feb 23, 2026
0d4fdba
Remove logger-HOI-lines
bouwew Feb 23, 2026
b741ebe
Bump to a13
bouwew Feb 23, 2026
b8771d8
Don't collect NodeInfo during pairing
bouwew Feb 23, 2026
2758f57
Update 0004-request
bouwew Feb 23, 2026
f49f5ba
Update test-related
bouwew Feb 23, 2026
19fda03
Ruffed
bouwew Feb 23, 2026
32e26be
Update docstring
bouwew Feb 23, 2026
c5e4c6c
Bump to a14
bouwew Feb 24, 2026
32a9aff
0005-response: add missing decode_mac=False
bouwew Feb 24, 2026
20b5bea
Add unknown StickResponseType 00C3
bouwew Feb 24, 2026
8260f67
Improve docstring
bouwew Feb 24, 2026
0ed8baf
Adapt 0005-test-response
bouwew Mar 2, 2026
4d978f0
Add init to StickNetworkInfoRequest
bouwew Mar 3, 2026
c46d5b7
And adapt use
bouwew Mar 3, 2026
d7a1b10
Disable guarding that breaks 0004-0005 sequence detection
bouwew Mar 4, 2026
60af99d
Fix CHANGELOG after rebase
bouwew Mar 4, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: Latest release

env:
CACHE_VERSION: 22
DEFAULT_PYTHON: "3.14"
DEFAULT_PYTHON: "3.13"

# Only run on merges
on:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: Latest commit

env:
CACHE_VERSION: 1
DEFAULT_PYTHON: "3.14"
DEFAULT_PYTHON: "3.13"
PRE_COMMIT_HOME: ~/.cache/pre-commit
VENV: venv

Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
- commitcheck
strategy:
matrix:
python-version: ["3.14"]
python-version: ["3.13"]
steps:
- name: Check out committed code
uses: actions/checkout@v6
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
# Changelog

## Ongoing

- PR [405](https://github.com/plugwise/python-plugwise-usb/pull/405): Try adding plus-device pairing (untested!!)

## v0.47.3 - 2026-03-04

- PR [418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve raise-message for better debugging
- PR [405](https://github.com/plugwise/python-plugwise-usb/pull/405): Fix recent Ruff errors
- PR [409](https://github.com/plugwise/python-plugwise-usb/pull/409): Fix recent Ruff errors

## v0.47.2 - 2026-01-29

Expand Down
37 changes: 28 additions & 9 deletions plugwise_usb/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,27 @@ def hardware(self) -> str:
return self._controller.hardware_stick

@property
def mac_stick(self) -> str:
"""MAC address of USB-Stick. Raises StickError is connection is missing."""
def mac_stick(self) -> str | None:
"""MAC address of USB-Stick.

Returns None when the connection to the Stick fails.
"""
return self._controller.mac_stick

@property
def mac_coordinator(self) -> str:
"""MAC address of the network coordinator (Circle+). Raises StickError is connection is missing."""
def mac_coordinator(self) -> str | None:
"""MAC address of the network coordinator (Circle+).

Returns none when there is no connection, not paired, not present in the network.
"""
return self._controller.mac_coordinator

@property
def name(self) -> str:
"""Return name of Stick."""
def name(self) -> str | None:
"""Return name of Stick.

Returns None when the connection to the Stick fails.
"""
return self._controller.stick_name

@property
Expand Down Expand Up @@ -237,8 +246,8 @@ async def setup(self, discover: bool = True, load: bool = True) -> None:
if not self.is_connected:
await self.connect()
if not self.is_initialized:
await self.initialize()
if discover:
initialized = await self.initialize()
if initialized and discover:
await self.start_network()
await self.discover_coordinator()
await self.discover_nodes()
Expand Down Expand Up @@ -266,10 +275,18 @@ async def connect(self, port: str | None = None) -> None:
self._port,
)

async def plus_pair_request(self, mac: str) -> bool:
"""Send a pair request to a Plus device."""
return await self._controller.pair_plus_device(mac)

@raise_not_connected
async def initialize(self, create_root_cache_folder: bool = False) -> None:
async def initialize(self, create_root_cache_folder: bool = False) -> bool:
"""Initialize connection to USB-Stick."""
await self._controller.initialize_stick()
# Check if network is offline = StickInitShortResponse
if self._controller.mac_coordinator is None:
return False

if self._network is None:
self._network = StickNetwork(self._controller)
self._network.cache_folder = self._cache_folder
Expand All @@ -278,6 +295,8 @@ async def initialize(self, create_root_cache_folder: bool = False) -> None:
if self._cache_enabled:
await self._network.initialize_cache()

return True

@raise_not_connected
@raise_not_initialized
async def start_network(self) -> None:
Expand Down
118 changes: 83 additions & 35 deletions plugwise_usb/connection/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,22 @@

from ..api import StickEvent
from ..constants import UTF8
from ..exceptions import NodeError, StickError
from ..helpers.util import version_to_model
from ..exceptions import MessageError, NodeError, StickError
from ..helpers.util import validate_mac, version_to_model
from ..messages.requests import (
CirclePlusConnectRequest,
NodeInfoRequest,
NodePingRequest,
PlugwiseRequest,
StickInitRequest,
StickNetworkInfoRequest,
)
from ..messages.responses import (
NodeInfoResponse,
NodePingResponse,
PlugwiseResponse,
StickInitResponse,
StickInitShortResponse,
)
from .manager import StickConnectionManager
from .queue import StickQueue
Expand Down Expand Up @@ -69,38 +72,27 @@ def hardware_stick(self) -> str | None:
return self._hw_stick

@property
def mac_stick(self) -> str:
"""MAC address of USB-Stick. Raises StickError when not connected."""
if not self._manager.is_connected or self._mac_stick is None:
raise StickError(
"No mac address available. Connect and initialize USB-Stick first."
)
def mac_stick(self) -> str | None:
"""MAC address of USB-Stick."""
return self._mac_stick

@property
def mac_coordinator(self) -> str:
"""Return MAC address of the Zigbee network coordinator (Circle+).

Raises StickError when not connected.
"""
if not self._manager.is_connected or self._mac_nc is None:
raise StickError(
"No mac address available. Connect and initialize USB-Stick first."
)
def mac_coordinator(self) -> str | None:
"""Return MAC address of the Zigbee network coordinator (Circle+)."""
return self._mac_nc

@property
def network_id(self) -> int:
"""Returns the Zigbee network ID. Raises StickError when not connected."""
if not self._manager.is_connected or self._network_id is None:
raise StickError(
"No network ID available. Connect and initialize USB-Stick first."
)
def network_id(self) -> int | None:
"""Returns the Zigbee network ID."""
return self._network_id

@property
def network_online(self) -> bool:
"""Return the network state."""
"""Return the network state.

The ZigBee network is online when the Stick is connected and a
StickInitResponse indicates that the ZigBee network is online.
"""
if not self._manager.is_connected:
raise StickError(
"Network status not available. Connect and initialize USB-Stick first."
Expand Down Expand Up @@ -159,7 +151,7 @@ async def _handle_stick_event(self, event: StickEvent) -> None:
elif event == StickEvent.DISCONNECTED and self._queue.is_running:
await self._queue.stop()

async def initialize_stick(self) -> None:
async def initialize_stick(self, node_info=True) -> None:
"""Initialize connection to the USB-stick."""
if not self._manager.is_connected:
raise StickError(
Expand All @@ -170,7 +162,9 @@ async def initialize_stick(self) -> None:

try:
request = StickInitRequest(self.send)
init_response: StickInitResponse | None = await request.send()
init_response: (
StickInitResponse | StickInitShortResponse | None
) = await request.send()
except StickError as err:
raise StickError(
"No response from USB-Stick to initialization request."
Expand All @@ -186,26 +180,80 @@ async def initialize_stick(self) -> None:
self._mac_stick = init_response.mac_decoded
self.stick_name = f"Stick {self._mac_stick[-5:]}"
self._network_online = init_response.network_online
if self._network_online:
# Replace first 2 characters by 00 for mac of circle+ node
self._mac_nc = init_response.mac_network_controller
self._network_id = init_response.network_id

# Replace first 2 characters by 00 for mac of circle+ node
self._mac_nc = init_response.mac_network_controller
self._network_id = init_response.network_id
self._is_initialized = True

# Add Stick NodeInfoRequest
if not node_info:
return

# Collect Stick NodeInfo
node_info, _ = await self.get_node_details(self._mac_stick, ping_first=False)
if node_info is not None:
self._fw_stick = node_info.firmware
self._fw_stick = node_info.firmware # type: ignore
hardware, _ = version_to_model(node_info.hardware)
self._hw_stick = hardware

if not self._network_online:
raise StickError("Zigbee network connection to Circle+ is down.")
async def pair_plus_device(self, mac: str) -> bool:
"""Pair Plus-device to Plugwise Stick.

According to https://roheve.wordpress.com/author/roheve/page/2/
The pairing process should look like:
0001 - 0002 - 0003: StickNetworkInfoRequest - StickNetworkInfoResponse - NodeSpecificResponse,
000A - 0011: StickInitRequest - StickInitShortResponse/StickInitResponse,
0004 - 0005: CirclePlusConnectRequest - CirclePlusConnectResponse,
the Plus-device will then send a NodeRejoinResponse (0061).

In the first occurrence of this process a 0004 0001 .... message is sent.
A StickInitShortResponse is received indicating the network is offline.
In the second occurrence of this process a 0004 0101 .... message is sent.
Again a StickInitShortResponse is received.
In the third occurrence only 000A is sent and a StickInitResponse indicating the network is online, is received.
"""
_LOGGER.debug("Pair Plus-device with mac: %s", mac)
if not validate_mac(mac):
raise NodeError(f"Pairing failed: MAC {mac} invalid")

# Collect network info
try:
request = StickNetworkInfoRequest(self.send)
info_response = await request.send()
except MessageError as exc:
raise NodeError(f"Pairing failed: {exc}") from exc
if info_response is None:
raise NodeError(
"Pairing failed, StickNetworkInfoResponse is None"
) from None

# Init Stick
try:
await self.initialize_stick(node_info=False)
except StickError as exc:
raise NodeError(
f"Pairing failed, failed to initialize Stick: {exc}"
) from exc

try:
request = CirclePlusConnectRequest(self.send, bytes(mac, UTF8))
response = await request.send()
except MessageError as exc:
raise NodeError(f"Pairing failed: {exc}") from exc
if response is None:
raise NodeError(
"Pairing failed, CirclePlusConnectResponse is None"
) from None
if response.allowed.value != 1:
raise NodeError("Pairing failed, not allowed")

return True

async def get_node_details(
self, mac: str, ping_first: bool
) -> tuple[NodeInfoResponse | None, NodePingResponse | None]:
"""Return node discovery type."""
"""Collect NodeInfo data from the Stick."""
ping_response: NodePingResponse | None = None
if ping_first:
# Define ping request with one retry
Expand Down Expand Up @@ -234,7 +282,7 @@ async def send(
return await self._queue.submit(request)
try:
return await self._queue.submit(request)
except (NodeError, StickError):
except NodeError, StickError:
return None

def _reset_states(self) -> None:
Expand Down
10 changes: 5 additions & 5 deletions plugwise_usb/connection/receiver.py
Original file line number Diff line number Diff line change
Expand Up @@ -441,11 +441,11 @@ async def _notify_node_response_subscribers(

notify_tasks: list[Coroutine[Any, Any, bool]] = []
for node_subscription in self._node_response_subscribers.values():
if (
node_subscription.mac is not None
and node_subscription.mac != node_response.mac
):
continue
# if (
# node_subscription.mac is not None
# and node_subscription.mac != node_response.mac
# ):
# continue
if (
node_subscription.response_ids is not None
and node_response.identifier not in node_subscription.response_ids
Expand Down
Loading
Loading