Skip to content

Fix/service catalog update schema mismatch#211

Open
Mary-Clb wants to merge 2 commits intomainfrom
fix/service-catalog-update-schema-mismatch
Open

Fix/service catalog update schema mismatch#211
Mary-Clb wants to merge 2 commits intomainfrom
fix/service-catalog-update-schema-mismatch

Conversation

@Mary-Clb
Copy link
Copy Markdown
Contributor

@Mary-Clb Mary-Clb commented May 5, 2026

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes Field is_displayed_onservicecatalog not created on plugin update #210
  • After the release of the Service Catalog display feature, some clients reported a fatal error on /ServiceCatalog during or just after plugin update.
    The root cause is a temporary schema mismatch: the code tries to use is_displayed_onservicecatalog before this column exists in glpi_plugin_news_alerts. Now, instead of a fatal SQL error, the plugin simply does not render alerts on the Service Catalog page until the schema migration is applied.

@Mary-Clb Mary-Clb requested review from Rom1-B and stonebuzz May 5, 2026 07:55
@Mary-Clb Mary-Clb self-assigned this May 5, 2026
@Mary-Clb Mary-Clb added the bug label May 5, 2026
Copy link
Copy Markdown
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're only addressing the symptom, but clearly the root cause lies in the migration process, since the field isn't always added to the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field is_displayed_onservicecatalog not created on plugin update

2 participants