Migrate GenericObject fields to Asset model fields#992
Closed
MyvTsv wants to merge 26 commits into
Closed
Conversation
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Contributor
Author
|
Missing element in the PR:
|
Rom1-B
requested changes
Aug 18, 2025
Comment on lines
+187
to
+190
| $query = "RENAME TABLE `$old_table` TO `$new_table`"; | ||
| if (!$DB->doQuery($query)) { | ||
| throw new \RuntimeException('Error renaming table: ' . $DB->error()); | ||
| } |
Contributor
There was a problem hiding this comment.
You can use $migration->renameTable($oldtable, $newtable)
Rom1-B
force-pushed
the
feature/glpi-11.0
branch
from
d1b9ec6 to
fa8fd5a
Compare
8 tasks
Contributor
|
Replaced by #996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Since the genericobject plugin has been replaced natively by Assets in glpi11, this PR migrates the fields for assets.