Fix(container): fix classname resolution when multiple 's' at end#1009
Merged
Conversation
Contributor
Author
|
Relying on the label introduces additional issues. For example, the |
Contributor
|
Isn't the real issue |
Contributor
Author
|
Accented characters are systematically removed by the I am somewhat hesitant to modify this behavior, especially considering the migration effort that would be required to restore everything correctly. |
Lainow
approved these changes
Sep 11, 2025
3834121 to
2f0e896
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Do not rely on
getSingular($container['name'])The current approach does not correctly convert names ending with double 's'.
For example:
'temps passé'→'tempspass'→<object>tempspas(in DB)'tempspass'when usinggetSingular(KO)'tempspas'when using internal process (OK)This PR replaces
getSingularwith an internal process to correctly convert the container name to the PHP class name, using:Toolbox->getSystemNameFromLabelPluginFieldsContainer::getClassname'tempspass'=>'PluginFields<object>tempspas'Screenshots (if appropriate):