Do not start a session on CRON context#85
Merged
Conversation
2 tasks
Rom1-B
reviewed
Oct 9, 2025
Rom1-B
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
See glpi-project/glpi#21383.
Variables pushed inside
$_SESSIONcannot be reused in CLI/CRON context. Therefore, there is no need to start a PHP session to save them. Not starting the PHP session should not be an issue in GLPI 11.0. This was probably necessary in GLPI 10.0 to initialize minimal session variables, but in GLPI 11.0 it is not necessary anymore as they are always initialized.