Skip to content

ci: use preinstalled browser binaries#397

Open
RedZapdos123 wants to merge 2 commits into
plotly:mainfrom
RedZapdos123:ci-fixes
Open

ci: use preinstalled browser binaries#397
RedZapdos123 wants to merge 2 commits into
plotly:mainfrom
RedZapdos123:ci-fixes

Conversation

@RedZapdos123
Copy link
Copy Markdown

@RedZapdos123 RedZapdos123 commented May 10, 2026

Description:

Maintainer requested that the CI fixes be split out from #392 into a separate PR.

This PR keeps only the CI/browser setup changes needed for the static export workflow:

  • add a setup-chrome step id in the clippy job so later steps can reliably consume action outputs.
  • adjust plotly_static webdriver download error handling so it fits the preinstalled browser/driver flow used in CI.

This keeps PR #397 scoped to CI fixes only.

Checklist:

  • I have reviewed all changes in this PR myself.
  • This PR does not include the axis-id/API changes from Type trace axis ids #392.
  • I have run formatting checks in WSL using cargo +nightly fmt --all -- --check and cd examples && cargo +nightly fmt --all -- --check.
  • I have run linting checks in WSL using cargo clippy -p plotly_static --features chromedriver,webdriver_download -- -D warnings -A deprecated and cargo clippy -p plotly_static --features geckodriver,webdriver_download -- -D warnings -A deprecated.
  • I have run focused local verification in WSL.

The verification screenshots of the tests run, locally:

image image image

@RedZapdos123 RedZapdos123 marked this pull request as ready for review May 10, 2026 15:02
@RedZapdos123 RedZapdos123 marked this pull request as draft May 10, 2026 15:03
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
@RedZapdos123 RedZapdos123 marked this pull request as ready for review May 22, 2026 02:18
@RedZapdos123 RedZapdos123 mentioned this pull request May 22, 2026
6 tasks
@RedZapdos123
Copy link
Copy Markdown
Author

I checked the semver failure on #397.

It is not caused by the CI fix in this PR. The only files changed here are .github/workflows/build.yml and plotly_static/build.rs, but the semver job is failing on plotly/src/traces/bar.rs because of the existing RestyleBar enum changes (ModifyBase and shifted discriminants).

So, this looks like from current main, not introduced by #397. Since #397 is now scoped only to CI fixes, I did not do an unrelated semver/API fix into this PR. I can open a new PR for that fix.

@andrei-ng
Copy link
Copy Markdown
Collaborator

I checked the semver failure on #397.

It is not caused by the CI fix in this PR. The only files changed here are .github/workflows/build.yml and plotly_static/build.rs, but the semver job is failing on plotly/src/traces/bar.rs because of the existing RestyleBar enum changes (ModifyBase and shifted discriminants).

So, this looks like from current main, not introduced by #397. Since #397 is now scoped only to CI fixes, I did not do an unrelated semver/API fix into this PR. I can open a new PR for that fix.

No worries. The semver failure is from previous changes done through other PRs. That will be fixed automatically when I make a new release.

Thanks for splitting the previous PR. I will review both asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants