Open
Conversation
Fixes plotly#5316 and plotly#4965. Also adds base64 option to to_json (plotly#5124).
Ported leftover type hinting work from previous session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimization: Annotation and shape append performance (O(N) -> O(1)) and Base64 JSON support.
This PR significantly improves the performance of adding annotations and shapes to a figure, particularly when dealing with large numbers of elements. It also introduces a requested feature for Base64 encoding in JSON serialization.
Technical Summary:
BaseFigureto avoid recursive, full-list validations when appending or extending annotations and layout shapes. This shifts the complexity frombase64encoding option toplotly.io.to_jsonto support embedding binary data more efficiently in JSON outputs. Fixes plotly.io.to_json method does not convert large numbers correctly #5124.test_annotated_shapes.pythat verifies both the correctness of the operations and the handling of edge cases for the new performance path.Code PR