Fix vline and vrect datetime object annotation mean calculation#5519
Open
mosh3eb wants to merge 1 commit intoplotly:mainfrom
Open
Fix vline and vrect datetime object annotation mean calculation#5519mosh3eb wants to merge 1 commit intoplotly:mainfrom
mosh3eb wants to merge 1 commit intoplotly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: Enhanced support for
datetimeobjects inadd_vlineandadd_vrectannotations.This fix addresses an issue where
add_vlineandadd_vrectfailed to correctly calculate annotation positions when usingdatetime.datetimeobjects on temporal axes.Technical Summary:
_mean()utility in plotly/basedatatypes.py to support date-like types by performing aggregation in numeric timestamp space (epoch milliseconds) before converting results back to ISO-formatted strings.vrect) and resolvesTypeErrorexceptions when attempting to compute positions for vertical lines (vline) on date-formatted axes.datetime.datetimeobject inputs for bothadd_vlineandadd_vrect.Code PR