Fix spurious engine deprecation warning in write_image#5517
Open
mosh3eb wants to merge 1 commit intoplotly:mainfrom
Open
Fix spurious engine deprecation warning in write_image#5517mosh3eb wants to merge 1 commit intoplotly:mainfrom
mosh3eb wants to merge 1 commit intoplotly:mainfrom
Conversation
write_image() defaulted engine='auto' and passed it to to_image(), which treats any non-None engine value as explicitly user-specified and emits a deprecation warning. By defaulting to None (matching to_image's expected interface), the warning only appears when the user actually passes an engine argument. Fixes plotly#5512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_image() defaulted engine='auto' and passed it to to_image(), which treats any non-None engine value as explicitly user-specified and emits a deprecation warning. By defaulting to None (matching to_image's expected interface), the warning only appears when the user actually passes an engine argument.
Fixes #5512