Deployment app new concept#8148
Open
sneridagh wants to merge 1 commit into
Open
Conversation
Documentation build overview
214 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been fiddling with an idea, in the direction of "have a real app" in the root of an add-on that we deploy. It's rough, but depicts the intention. I had a good conversation with the machine about it that we can evolve around it. Good things is that we can improve it in many ways in a sustainable way. What is less ideal, is that we will have to maintain that "app scaffold" instead of having it centralized it in
core/apps/seven... but at the end, it's the same, if you "clone" it from the source. The question might be what would be that "canonical" source... the code itself in the checkout? a tar.gz download + extract it, then copy? release an app seems not a good idea... at the end it's scaffold...UPDATE: The "clone" approach has to be updated with a released artifact approach, for sure when we release seven for the first time, by all means. However, the re-scaffolding, has its own advantages, for sure... (eg. not having to maintain it).
Related PR in cookieplone-templates: plone/cookieplone-templates#394