Docs: Clarify running make install when changing dependencies#7944
Conversation
|
@stevepiercy I have just changed docs and it is showing failure for control pannel test is it flakey test ? |
|
@stevepiercy Can u please review this. |
|
@stevepiercy any updates on reviewing this PR |
|
@stevepiercy Can u please review this PR |
1 similar comment
|
@stevepiercy Can u please review this PR |
|
@stevepiercy Can u please review this PR |
|
@wesleybl Thanks for review |
davisagli
left a comment
There was a problem hiding this comment.
This looks good to me too. @stevepiercy do you want to do any copy editing before we merge?
stevepiercy
left a comment
There was a problem hiding this comment.
Thanks for your contribution and patience. Sorry for the long delay for an editorial review. I have months of PRs and volunteer editorial backlog to work through. I'll get to the rest eventually. The PRs that get a technical review from other folks will get bumped up in my priority queue. "Many hands..."
|
@stevepiercy Thanks for review I will make recomended changes as soon as I get some free time |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
I applied @stevepiercy's suggestions. Okay to merge now? |
|
@davisagli Thanks for helping me out @stevepiercy Thanks for ur time |
Issue #7922
Summary
Add documentation clarifying that contributors must run
make installand commit the updatedpnpm-lock.yamlwhen changing dependencies.Changes
Added notes in the following documentation pages:
These notes explain:
make installafter changing dependenciespnpm-lock.yamlCloses #7922
📚 Documentation preview 📚: https://volto--7944.org.readthedocs.build/