Skip to content

Docs: Clarify running make install when changing dependencies#7944

Merged
stevepiercy merged 6 commits into
plone:mainfrom
Manik-Khajuria-5:7922-document-make-install-when-changing-dependency
May 27, 2026
Merged

Docs: Clarify running make install when changing dependencies#7944
stevepiercy merged 6 commits into
plone:mainfrom
Manik-Khajuria-5:7922-document-make-install-when-changing-dependency

Conversation

@Manik-Khajuria-5
Copy link
Copy Markdown
Member

@Manik-Khajuria-5 Manik-Khajuria-5 commented Feb 24, 2026


Issue #7922


Summary

Add documentation clarifying that contributors must run make install and commit the updated pnpm-lock.yaml when changing dependencies.

Changes

Added notes in the following documentation pages:

  • acceptance-tests.md
  • developing-core.md
  • testing.md

These notes explain:

  • Run make install after changing dependencies
  • Commit the updated pnpm-lock.yaml
  • Prevent CI and acceptance test failures caused by outdated lockfiles


screenshot-2026-02-24_19-31-58 ----- screenshot-2026-02-24_19-32-11

Closes #7922



📚 Documentation preview 📚: https://volto--7944.org.readthedocs.build/

@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy I have just changed docs and it is showing failure for control pannel test is it flakey test ?

@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy Can u please review this.

@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy any updates on reviewing this PR

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 10, 2026

@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy Can u please review this PR

1 similar comment
@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy Can u please review this PR

@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy Can u please review this PR

@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@wesleybl Thanks for review

@wesleybl wesleybl requested a review from stevepiercy May 26, 2026 01:24
Copy link
Copy Markdown
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too. @stevepiercy do you want to do any copy editing before we merge?

Copy link
Copy Markdown
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and patience. Sorry for the long delay for an editorial review. I have months of PRs and volunteer editorial backlog to work through. I'll get to the rest eventually. The PRs that get a technical review from other folks will get bumped up in my priority queue. "Many hands..."

Comment thread docs/source/contributing/developing-core.md Outdated
Comment thread docs/source/contributing/developing-core.md Outdated
Comment thread docs/source/contributing/developing-core.md Outdated
Comment thread docs/source/contributing/developing-core.md Outdated
Comment thread docs/source/contributing/developing-core.md Outdated
Comment thread docs/source/contributing/acceptance-tests.md Outdated
Comment thread docs/source/contributing/testing.md Outdated
Comment thread docs/source/contributing/acceptance-tests.md Outdated
Comment thread docs/source/contributing/developing-core.md Outdated
Comment thread packages/volto-slate/news/7944.internal Outdated
@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@stevepiercy Thanks for review I will make recomended changes as soon as I get some free time

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@davisagli
Copy link
Copy Markdown
Member

I applied @stevepiercy's suggestions. Okay to merge now?

@davisagli davisagli requested a review from stevepiercy May 27, 2026 08:54
@stevepiercy stevepiercy enabled auto-merge (squash) May 27, 2026 10:08
@stevepiercy stevepiercy disabled auto-merge May 27, 2026 10:11
@stevepiercy stevepiercy enabled auto-merge (squash) May 27, 2026 10:11
@stevepiercy stevepiercy merged commit 5cec2a6 into plone:main May 27, 2026
49 checks passed
@Manik-Khajuria-5
Copy link
Copy Markdown
Member Author

@davisagli Thanks for helping me out @stevepiercy Thanks for ur time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document to run make install when changing a dependency

4 participants