Flexible docker image name generation depending on the container registry#402
Open
erral wants to merge 1 commit into
Open
Flexible docker image name generation depending on the container registry#402erral wants to merge 1 commit into
erral wants to merge 1 commit into
Conversation
Member
Author
|
This supercedes plone/cookieplone#68 @avoinea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements flexible Docker image name generation based on the selected container registry.
Key changes:
__container_registry_prefix_separatorto choose between-(GitHub/Docker Hub) and/(GitLab).__container_image_prefixto include the separator.Verified with pytest (9 new test cases passing).