Skip to content

Unified Project: Single Project and Settings for Volto/Classic projects#400

Open
erral wants to merge 20 commits into
nextfrom
unify-sub-project-settings
Open

Unified Project: Single Project and Settings for Volto/Classic projects#400
erral wants to merge 20 commits into
nextfrom
unify-sub-project-settings

Conversation

@erral
Copy link
Copy Markdown
Member

@erral erral commented May 20, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

This PR completes the unification of the monorepo and classic templates

Summary of Changes

  • Implemented a "Safe Default + Prompt Override" pattern in cookieplone.json: static defaults are provided at the top level to ensure context presence, while dynamic prompts are handled within the allOf conditional block.

  • Guarded Frontend Mentions: Added Jinja2 guards to the generated README.md and other files to ensure that frontend-specific sections only appear when feature_headless is enabled.

  • Enhanced Test Coverage:

    • Added tests/templates/projects/monorepo/test_project_classic.py to explicitly verify Classic UI project generation (checking for the absence of the frontend folder and presence of correct metadata).
    • Updated tests/templates/projects/monorepo/test_project_variables.py to match the current set of expected variables.
    • Template Robustness: Verified that all 297 tests for the monorepo template now pass in both Headless and Classic modes.

Key Files Affected

  • templates/projects/monorepo/cookieplone.json: Main project schema and logic.
  • templates/projects/monorepo/{{ cookiecutter.__folder_name }}/README.md: Protected frontend-related strings.
  • tests/templates/projects/monorepo/test_project_classic.py: New verification suite for Classic mode.
  • tests/templates/projects/monorepo/test_project_variables.py: Updated variable assertions.

@erral erral requested review from ericof, pbauer and sneridagh as code owners May 20, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant