Fixes default python version in Dockerfile#397
Open
sneridagh wants to merge 3 commits into
Open
Conversation
sneridagh
changed the title
davisagli
requested changes
May 11, 2026
| @@ -1,5 +1,5 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| ARG PYTHON_VERSION=3.12 | |||
| ARG PYTHON_VERSION=3.13 | |||
Member
There was a problem hiding this comment.
This should use the same variable that we do in other files: {{ cookiecutter.__supported_versions_python[0] }}
(Different versions of the Plone backend support different ranges of Python versions. With 6.2 this should be Python 3.14)
Member
There was a problem hiding this comment.
But also: this is just a default and normally this arg should be passed in. I asked for some more info about the context where you were running it in #396 so we can confirm what's missing.
Member
There was a problem hiding this comment.
Just added the parametrization for the image build
Member
There was a problem hiding this comment.
@ericof Can we then change this line to
Suggested change
| ARG PYTHON_VERSION=3.13 | |
| ARG PYTHON_VERSION=undefined |
so it is more obvious if it somehow gets built without proper parameterization?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #396